Add optional AEP generation method for enhanced site compatibility

Author: adrium

README.md

@@ -14,6 +14,7 @@ Differences to the original version:
 * Show the passwords concealed to use drag and drop
 * Smaller theme with accent color
 * Sync works, but disabled due to missing API keys
+* Add new AEP password generation method to ensure 2 characters of every charset and symbol compatibility (with sites like ebay.com)
 
 Using multiple master passwords
 -------------------------------

lib/crypto.js

@@ -214,7 +214,8 @@ export function derivePasswordUniversal(params)
 {
   let types = {
     generated: {hasher: deriveBitsLegacy, stringifier: toPassword},
-    generated2: {hasher: deriveBits, stringifier: toPassword}
+    generated2: {hasher: deriveBits, stringifier: toPassword},
+    generatedAep: {hasher: deriveBits, stringifier: toPasswordAep}
   };
 
   let impl = types[params.type];
@@ -251,6 +252,22 @@ function toPassword(array, lower, upper, number, symbol)
   return toPasswordUniversal(array, charsettings);
 }
 
+function toPasswordAep(array, lower, upper, number, symbol)
+{
+  let charsettings = [];
+
+  if (lower)
+    charsettings.push({charset: "abcdefghijklmnopqrstuvwxyz", min: 2, max: 1024});
+  if (upper)
+    charsettings.push({charset: "ABCDEFGHIJKLMNOPQRSTUVWXYZ", min: 2, max: 1024});
+  if (number)
+    charsettings.push({charset: "0123456789", min: 2, max: 1024});
+  if (symbol)
+    charsettings.push({charset: "!#$%&*+-?@", min: 2, max: 1024});
+
+  return toPasswordUniversal(array, charsettings);
+}
+
 function toPasswordUniversal(array, charsettings)
 {
   for (let s of charsettings)

lib/passwords.js

@@ -346,7 +346,7 @@ export function setSite(entry)
   });
 }
 
-export function addGenerated({site, name, revision, length, lower, upper, number, symbol, notes}, replaceExisting)
+export function addGenerated({site, name, revision, length, lower, upper, number, symbol, notes, type_aep}, replaceExisting)
 {
   return lock.acquire().then(() => _ensureSiteData(site)).then(() =>
   {
@@ -362,7 +362,7 @@ export function addGenerated({site, name, revision, length, lower, upper, number
     if (exists)
       throw "alreadyExists";
 
-    let type = "generated2";
+    let type = type_aep ? "generatedAep" : "generated2";
     let data = {
       site, name, revision, type, length, lower, upper, number, symbol
     };

locale/en_US/panel/components/GeneratedPassword.json

@@ -2,6 +2,8 @@
   "replace_warning": "Making this a generated password will change its value. Make sure that you already filled in \"current password\" in the website's password change form.",
   "keep_notes": "Keep notes from original password",
   "length_label": "Length:",
+  "type_aep_label": "AEP generation method",
+  "type_aep_title": "Generates passwords that are more compatible with certain sites (ensures 2 characters of every charset and uses less symbols)",
   "allowed_characters_label": "Allowed characters:",
   "submit": "Generate password",
 

locale/en_US/panel/components/PasswordEntry.json

@@ -1,5 +1,6 @@
 {
   "password_menu": "All actions",
+  "password_type_generatedAep": "Generated AEP password",
   "password_type_generated2": "Generated password",
   "password_type_stored": "Stored password",
   "password_length": "Length:",

manifest.json

@@ -14,7 +14,7 @@
   "description": "__MSG_description__",
   "author": "Wladimir Palant / Adrium",
   "homepage_url": "https://github.com/adrium/easypass",
-  "version": "2.2.3",
+  "version": "2.2.3.2020",
   "permissions": [
     "activeTab",
     "storage",

media/screenshot2.png

@@ -25,8 +25,8 @@
       <iconic-link class="password-remove-link" :title="$t('/(panel)(components)(PasswordMenu)remove_password')" @click="removePassword" />
     </div>
     <div class="password-info">
-      <template v-if="password.type == 'generated2'">
-        <div class="password-type">{{ $t("/(panel)(components)(PasswordEntry)password_type_generated2") }}</div>
+      <template v-if="password.type.indexOf('generated') == 0">
+        <div class="password-type">{{ $t("/(panel)(components)(PasswordEntry)password_type_" + password.type) }}</div>
         <div>{{ $t("/(panel)(components)(PasswordEntry)password_length") }} {{ password.length }}</div>
         <div>{{ $t("/(panel)(components)(PasswordEntry)allowed_characters") }}  {{ allowedChars }}</div>
       </template>

ui/allpasswords/components/PasswordInfo.vue

@@ -33,6 +33,9 @@
         <label><input v-model="number" type="checkbox">789</label>
         <label><input v-model="symbol" type="checkbox">+^;</label>
       </div>
+      <div class="charsets-container">
+        <label :title="$t('type_aep_title')"><input v-model="type_aep" type="checkbox">{{ $t("type_aep_label") }}</label>
+      </div>
 
       <!-- Charset checkboxes are aggregated into a single hidden input to simplify validation -->
       <validated-input v-model="charsets" :error.sync="charsetsError" :visible="false" @validate="validateCharsets" />
@@ -98,6 +101,7 @@ export default {
       upper: getProp("upper", true),
       number: getProp("number", true),
       symbol: getProp("symbol", true),
+      type_aep: getProp("type_aep", false),
       charsets: "",
       charsetsError: null,
       keepNotes: !!this.password
@@ -148,6 +152,7 @@ export default {
         upper: this.upper,
         number: this.number,
         symbol: this.symbol,
+        type_aep: this.type_aep,
         notes: this.keepNotes ? this.password.notes : null
       }, this.options.replacing).then(pwdList =>
       {

ui/panel/components/GeneratedPassword.vue

@@ -74,9 +74,9 @@ export default {
     {
       let tooltip = "";
       let password = this.password;
-      if (password.type == "generated2")
+      if (password.type.indexOf("generated") == 0)
       {
-        tooltip = this.$t("password_type_generated2");
+        tooltip = this.$t("password_type_" + password.type);
 
         tooltip += "\n" + this.$t("password_length");
         tooltip += " " + password.length;