External test: derby: must include junit.jar

[llxia]

https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_extended.external_x86-64_linux_derby/2/console

12:23:04  junit-pptesting:
12:23:04  
12:23:04  BUILD FAILED
12:23:04  /derby/build.xml:2572: The <classpath> or <modulepath> for <junit> must include junit.jar if not in Ant's own classpath
12:23:04  

[smlambert]

Think this is related to 501 error and using http versus https which I think @james-crowley told me about, but did not get turned into an action.

He noted thqt from going to the URL, it states that you need to use HTTPS not just HTTP
http://repo1.maven.org/maven2/junit/junit/3.8.2/junit-3.8.2.jar needs to change to https://repo1.maven.org/maven2/junit/junit/3.8.2/junit-3.8.2.jar

but the download works on HTTPS

I think the upstream issue is: https://issues.apache.org/jira/browse/DERBY-7065

12:21:27 install_junit:
12:21:27 [get] Getting: http://repo1.maven.org/maven2/junit/junit/3.8.2/junit-3.8.2.jar
12:21:27 [get] To: /derby/tools/java/junit.jar
12:21:27 [get] Error opening connection java.io.IOException: Server returned HTTP response code: 501 for URL: http://repo1.maven.org/maven2/junit/junit/3.8.2/junit-3.8.2.jar
12:21:27 [get] Error opening connection java.io.IOException: Server returned HTTP response code: 501 for URL: http://repo1.maven.org/maven2/junit/junit/3.8.2/junit-3.8.2.jar
12:21:27 [get] Error opening connection java.io.IOException: Server returned HTTP response code: 501 for URL: http://repo1.maven.org/maven2/junit/junit/3.8.2/junit-3.8.2.jar
12:21:27 [get] Can't get http://repo1.maven.org/maven2/junit/junit/3.8.2/junit-3.8.2.jar to /derby/tools/java/junit.jar
12:21:27

[smlambert]

[2020-11-22T04:59:10.038Z] install_junit:
[2020-11-22T04:59:10.038Z] [get] Getting: http://repo1.maven.org/maven2/junit/junit/3.8.2/junit-3.8.2.jar
[2020-11-22T04:59:10.038Z] [get] To: /derby/tools/java/junit.jar
[2020-11-22T04:59:10.038Z] [get] Error opening connection java.io.IOException: Server returned HTTP response code: 501 for URL: http://repo1.maven.org/maven2/junit/junit/3.8.2/junit-3.8.2.jar
[2020-11-22T04:59:10.038Z] [get] Error opening connection java.io.IOException: Server returned HTTP response code: 501 for URL: http://repo1.maven.org/maven2/junit/junit/3.8.2/junit-3.8.2.jar
[2020-11-22T04:59:10.038Z] [get] Error opening connection java.io.IOException: Server returned HTTP response code: 501 for URL: http://repo1.maven.org/maven2/junit/junit/3.8.2/junit-3.8.2.jar
[2020-11-22T04:59:10.038Z] [get] Can't get http://repo1.maven.org/maven2/junit/junit/3.8.2/junit-3.8.2.jar to /derby/tools/java/junit.jar

The mirror we pull derby code from is not up-to-date with derby development branch, it still uses http maven junit.url (which no longer works, see apache/derby#17 for a 'fix') versus https. If this mirror is not keeping current with the updates to the derby application, we should stop using it as our basis, and suggest we use tagged download of latest stable version of derby instead. (EDIT: I see that the mirror is updating, but need to figure out from what svn tag, which must not have the updated https junit.url)

[smlambert]

Will revisit health of external test targets after #6766 is completed, closing these older issues as stale.