fix: pydantic >= 2.0 and enforce required metadata fields and move test data to fixture#30
Closed
sgomezvillamor wants to merge 1 commit intomainfrom
Closed
fix: pydantic >= 2.0 and enforce required metadata fields and move test data to fixture#30sgomezvillamor wants to merge 1 commit intomainfrom
sgomezvillamor wants to merge 1 commit intomainfrom
Conversation
- Add assertions in Metadata.__post_init__ to validate required fields - Change Metadata fields from Optional[str] to str (avoid breaking change) - Move module-level test data loading to session-scoped pytest fixture - Fix pytest hanging during collection phase
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Author
|
not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump pydantic >= 2.0
Additionally, fixed mypy type inconsistencies and pytest collection hanging.
Changes
Testing