Skip to content
This repository was archived by the owner on Oct 18, 2023. It is now read-only.

Remove unnecessary static cache. #156

Open
nikunjkotecha wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from
Open

Remove unnecessary static cache. #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions modules/acm_sku/src/Entity/SKU.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,22 +100,12 @@ public static function preCreate(EntityStorageInterface $storage_controller, arr
*/
public static function loadFromSku($sku, $langcode = '', $log_not_found = TRUE, $create_translation = FALSE) {

$skus_static_cache = &drupal_static(__FUNCTION__, []);

$is_multilingual = \Drupal::languageManager()->isMultilingual();
if ($is_multilingual && empty($langcode)) {
$langcode = \Drupal::languageManager()->getCurrentLanguage()->getId();
}

$static_cache_sku_identifier = $sku . ':' . $langcode;

// Check if data is available in static cache, return from there.
// If create translation is true, it means we are doing product sync.
// For this case we don't want to use any static cache.
if (isset($skus_static_cache[$static_cache_sku_identifier]) && !$create_translation) {
return $skus_static_cache[$static_cache_sku_identifier];
}

$storage = \Drupal::entityTypeManager()->getStorage('acm_sku');
$skus = $storage->loadByProperties(['sku' => $sku]);

Expand Down Expand Up @@ -154,11 +144,6 @@ public static function loadFromSku($sku, $langcode = '', $log_not_found = TRUE,
if ($is_multilingual) {
if ($sku_entity->hasTranslation($langcode)) {
$sku_entity = $sku_entity->getTranslation($langcode);

// Set value in static variable.
// We set in static cache only for proper case, when returning different
// language or creating translation we can avoid static cache.
$skus_static_cache[$static_cache_sku_identifier] = $sku_entity;
}
elseif ($create_translation) {
$sku_entity = $sku_entity->addTranslation($langcode, ['sku' => $sku]);
Expand All @@ -169,10 +154,6 @@ public static function loadFromSku($sku, $langcode = '', $log_not_found = TRUE,
\Drupal::logger('acm_sku')->error('SKU translation not found of @sku for @langcode', ['@sku' => $sku, '@langcode' => $langcode]);
}
}
else {
// Set value in static variable directly if not a multi-lingual site.
$skus_static_cache[$static_cache_sku_identifier] = $sku_entity;
}

return $sku_entity;
}
Expand Down