From 8faf033deedb3506aad0c87a834513af5e5a8b3e Mon Sep 17 00:00:00 2001 From: nikunj Date: Thu, 30 May 2019 21:12:21 +0530 Subject: [PATCH] Remove unnecessary static cache. --- modules/acm_sku/src/Entity/SKU.php | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/modules/acm_sku/src/Entity/SKU.php b/modules/acm_sku/src/Entity/SKU.php index 2c0229f..84f111b 100644 --- a/modules/acm_sku/src/Entity/SKU.php +++ b/modules/acm_sku/src/Entity/SKU.php @@ -100,22 +100,12 @@ public static function preCreate(EntityStorageInterface $storage_controller, arr */ public static function loadFromSku($sku, $langcode = '', $log_not_found = TRUE, $create_translation = FALSE) { - $skus_static_cache = &drupal_static(__FUNCTION__, []); $is_multilingual = \Drupal::languageManager()->isMultilingual(); if ($is_multilingual && empty($langcode)) { $langcode = \Drupal::languageManager()->getCurrentLanguage()->getId(); } - $static_cache_sku_identifier = $sku . ':' . $langcode; - - // Check if data is available in static cache, return from there. - // If create translation is true, it means we are doing product sync. - // For this case we don't want to use any static cache. - if (isset($skus_static_cache[$static_cache_sku_identifier]) && !$create_translation) { - return $skus_static_cache[$static_cache_sku_identifier]; - } - $storage = \Drupal::entityTypeManager()->getStorage('acm_sku'); $skus = $storage->loadByProperties(['sku' => $sku]); @@ -154,11 +144,6 @@ public static function loadFromSku($sku, $langcode = '', $log_not_found = TRUE, if ($is_multilingual) { if ($sku_entity->hasTranslation($langcode)) { $sku_entity = $sku_entity->getTranslation($langcode); - - // Set value in static variable. - // We set in static cache only for proper case, when returning different - // language or creating translation we can avoid static cache. - $skus_static_cache[$static_cache_sku_identifier] = $sku_entity; } elseif ($create_translation) { $sku_entity = $sku_entity->addTranslation($langcode, ['sku' => $sku]); @@ -169,10 +154,6 @@ public static function loadFromSku($sku, $langcode = '', $log_not_found = TRUE, \Drupal::logger('acm_sku')->error('SKU translation not found of @sku for @langcode', ['@sku' => $sku, '@langcode' => $langcode]); } } - else { - // Set value in static variable directly if not a multi-lingual site. - $skus_static_cache[$static_cache_sku_identifier] = $sku_entity; - } return $sku_entity; }