Skip to content

Comments

fix: deploy script#56

Merged
musale merged 3 commits intomainfrom
fix/deploy
Aug 18, 2025
Merged

fix: deploy script#56
musale merged 3 commits intomainfrom
fix/deploy

Conversation

@musale
Copy link
Contributor

@musale musale commented Aug 18, 2025

This pull request updates the conditional expressions in the .github/workflows/deploy-pages.yml workflow file to improve readability and ensure correct evaluation of expressions in GitHub Actions. The main focus is on making the if conditions for the build and deploy jobs more explicit and robust.

Workflow improvements:

  • Updated the if condition for the build job to use a multi-line format and explicitly wrap the startsWith function with ${{ ... }} for proper evaluation in GitHub Actions.
  • Updated the if condition for the deploy job in the same way, ensuring consistency and correct behavior in workflow execution.

@musale musale requested a review from Copilot August 18, 2025 21:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes GitHub Actions workflow conditional expressions by updating the if conditions in the deploy pages workflow to use proper syntax and improve readability. The changes ensure that the startsWith function is correctly evaluated within GitHub Actions expressions.

  • Updates conditional expressions to use multi-line format for better readability
  • Wraps the startsWith function with ${{ ... }} syntax for proper GitHub Actions evaluation
  • Applies consistent formatting to both build and deploy job conditions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

musale and others added 2 commits August 19, 2025 00:42
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@musale musale merged commit 1b1008d into main Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant