-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Root cause:
The method to authenticate Github Actions code to Google Cloud is described here (this is code provided by Google). After a checkout of the repository, the authentication methods create temporary JSON files in the repository folders. However, nbdev 2.0 CI code checks out the repository again using the Github actions/checkout@v3 with the default clean=true option, overwriting the Google Cloud JSON authentication files. Subsequent calls to Google Cloud therefore cannot be authenticated anymore.
The proper way to fix this would be:
- Fork
fastai/workflows - Add an option
clean_repotofastai/workflows/nbdev-ci/actions.ymlto allow setting thecleanoption foractions/checkout@v3(default:true) - Add the code to add Google Cloud authentication to this repository in
.github/workflows/test.yamlwith the optionclean_repo=falseset - Test this fix with the forked fastai workflows
- Submit PR to fastai
- After PR is accepted change
.github/workflows/test.yamlto usefastai/workflowsagain instead of the fork
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request