auto-rename if filename already present

[abuzarmahmood]

rename prior to uploading

[abuzarmahmood]

The issue at hand involves implementing an auto-renaming feature for files if the filename is already present before uploading to an S3 bucket. The following suggestions and changes were made by the agents:

1. Relevant Files:

   • File: /home/exouser/Desktop/blech_github_bot/src/repos/abuzarmahmood/ocr_database/src/pages/Upload.py
     • Description: This file likely handles the upload functionality and interacts with an S3 bucket. It needs modifications to check for existing filenames and rename the file if necessary before uploading.
   • File: /home/exouser/Desktop/blech_github_bot/src/repos/abuzarmahmood/ocr_database/src/_tests/s3_test.py
     • Description: This file is related to testing S3 interactions. It should include tests to ensure that the auto-renaming functionality works as expected.

2. Modifications in Upload.py:

   • Check for Existing Filenames: Before uploading, check if the file already exists in the S3 bucket. If it does, rename the file by appending a unique identifier (e.g., a timestamp or a counter).
   • Code Changes: Modify the code around the file upload section to include the renaming logic.

   Suggested code snippet to add in Upload.py:

   import time
   
   def get_unique_filename(s3, path, filename):
       base, ext = os.path.splitext(filename)
       counter = 1
       new_filename = filename
       while s3.exists(os.path.join(path, new_filename)):
           new_filename = f"{base}_{int(time.time())}_{counter}{ext}"
           counter += 1
       return new_filename
   
   # Inside the form submission logic
   if submit_button:
       if uploaded_file is not None:
           # Get a unique filename
           unique_filename = get_unique_filename(s3, save_path, uploaded_file.name)
           
           # Use unique_filename instead of uploaded_file.name
           save_page_path = os.path.join(
               save_path,
               unique_filename.split('.')[0] + '_' + str(i) + '.pdf'
           )
           
           # Continue with the existing upload logic

3. Modifications in s3_test.py:

   • Add Tests for Auto-Renaming: Create tests to verify that files are renamed correctly when a filename conflict occurs.

   Suggested test case to add in s3_test.py:

   def test_auto_rename_on_conflict():
       # Setup: Upload a file with a known name
       original_filename = 'test_file.pdf'
       s3.put(original_filename, f's3://ocr-database-s3/{original_filename}')
       
       # Attempt to upload the same file again
       new_filename = get_unique_filename(s3, 's3://ocr-database-s3', original_filename)
       s3.put(original_filename, f's3://ocr-database-s3/{new_filename}')
       
       # Assert: Check that the new file exists with a different name
       assert s3.exists(f's3://ocr-database-s3/{new_filename}')
       assert new_filename != original_filename

These changes should address the issue of auto-renaming files if the filename is already present before uploading. Testing thoroughly is recommended to ensure the functionality works as expected.

---

This response was automatically generated by blech_bot

[abuzarmahmood]

[ develop_issue ]

[abuzarmahmood]

Created pull request: #11
Continue discussion there.

---

This response was automatically generated by blech_bot