'merge' fact and facts

[toepi]

class puppet::facts and define puppet::fact has a similar template, to supported structured_facts you must change both. Why not use puppet::fact inside puppet::facts - the only drawback no longer a local.yaml? This also mean you can manage ${facterbasepath}/facts.d every time and not only if some custom_facts are provided.

[rendhalver]

Good point.
I should move the directory management out of puppet::facts.

[rendhalver]

I think idea behind puppet::facts existed before the puppet::fact define was created.
I could change it to use the define internally but I am not a big fan of create_resources.

[rendhalver]

The fix I made for this in #65 should fix the problem.

[toepi]

Sorry for the delay. Main "issue" two templates are still remaining? If you don't want use create_resources, why not use concat and put facts only into local.yaml? But think create_resources for custom_facts would be a good solution to minimize duplication; Benefit file is called like the fact it is presenting every time. So you can check which facts are on the node you need a ls only and not an ls and and cat local.yaml.