Mixed resource-like and include-like invocation of ::puppet

[chrisowensboston]

The puppet documentation warns against mixing resource-like and include-like invocations of the same class docs here. I believe it is because this introduces a dependency on evaluation order, which can lead to extremely pernicious bugs.

In manifests/master/install.pp (and a lot of other places) we include ::puppet
in manifests/profile/agent.pp we use resource-like declaration of ::puppet

I'm thinking this might be resolved by forcing profile/agent.pp to be evaluated before any other class that includes ::puppet, but that doesn't feel architecturally sound.

[chrisowensboston]

I've worked around this in my own profiles by always evaluating profile/agent before profile/master.

[rendhalver]

I use a resource like declaration in the profiles so I can configure the classes with profile variables.
I believe this is a better way to do profiles.
The profiles I have added are mostly for example on how it works.
Feel free to rewrite them for your own infrastructure.