From e3705f19fa7b955e1aa2843ad894a22a43bada01 Mon Sep 17 00:00:00 2001
From: Andrew Bromwich <a.bromwich@gmail.com>
Date: Tue, 14 Jan 2025 01:36:32 +1000
Subject: [PATCH 1/2] Add support for Ruby 3.4

---
 Gemfile                              | 8 ++++----
 lib/rocket_chat/messages/settings.rb | 2 +-
 rocketchat.gemspec                   | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Gemfile b/Gemfile
index 9b0a981..090b011 100644
--- a/Gemfile
+++ b/Gemfile
@@ -8,10 +8,10 @@ gemspec
 gem 'bundler', ['>= 1.11', '< 3.0']
 gem 'rake', '>= 12.3.3'
 gem 'rspec', '~> 3.0'
-gem 'rubocop', '~> 1.28'
-gem 'rubocop-performance', '~> 1.13'
+gem 'rubocop', '~> 1.70'
+gem 'rubocop-performance', '~> 1.23'
 gem 'rubocop-rake', '~> 0.6'
-gem 'rubocop-rspec', '~> 2.10'
+gem 'rubocop-rspec', '~> 3.3'
 gem 'simplecov', '~> 0.16', '< 0.18'
-gem 'webmock', '~> 3.12'
+gem 'webmock', '~> 3.24'
 gem 'yard', '~> 0.9.11'
diff --git a/lib/rocket_chat/messages/settings.rb b/lib/rocket_chat/messages/settings.rb
index 2031d77..f25b966 100644
--- a/lib/rocket_chat/messages/settings.rb
+++ b/lib/rocket_chat/messages/settings.rb
@@ -36,7 +36,7 @@ def []=(id, value)
           }
         )
 
-        value if response['success']
+        value if response['success'] # rubocop:disable Lint/Void
       end
 
       private
diff --git a/rocketchat.gemspec b/rocketchat.gemspec
index d62e35b..2356b6a 100644
--- a/rocketchat.gemspec
+++ b/rocketchat.gemspec
@@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
   spec.description   = 'Rocket.Chat REST API v1 for Ruby'
   spec.homepage      = 'https://github.com/abrom/rocketchat-ruby'
   spec.license       = 'MIT'
-  spec.required_ruby_version = ['>= 3.0.0', '< 3.4.0']
+  spec.required_ruby_version = ['>= 3.0.0', '< 3.5.0']
 
   # Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or
   # delete this section to allow pushing this gem to any host.

From 60586faeec160d546e1d0834c80a0d7374e76b31 Mon Sep 17 00:00:00 2001
From: Andrew Bromwich <a.bromwich@gmail.com>
Date: Tue, 14 Jan 2025 01:37:51 +1000
Subject: [PATCH 2/2] Add Ruby 3.4 to the CI matrix

---
 .github/workflows/test.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index e363c2f..615900d 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['3.0', '3.1', '3.2', '3.3']
+        ruby-version: ['3.0', '3.1', '3.2', '3.3', '3.4']
 
     steps:
       - uses: actions/checkout@v4