Print Pickups / Webforms

[eby]

Just dumping this here since finally getting around to working on the holdtix side and looking through tables, etc. I haven't dug in code so some of this might be wrong about the design and can be ignored. Just based on my kicking.

Not sure which solutions are easiest. Changing the update submission permission to just be ONS so only a few people to keep procedures straight might be easier than code changes.

1. Staff are used to cancel/reschedule workflow. Once a print job is approved the pickup date is pretty much set in stone. I could see staff thinking they can tweak that on the submission and it will change the appointment. Whoever has access to update will need to know not to change it. I presume these pickups can't be canceled or can they?

2. Similar with changing pickup location etc.

3. Right now it is possible to create duplicates by toggling the completed. I've tested other things like adding attachments and it seems like it doesn't make a duplicate unless the approved field changes so we might not need the duplicate check if staff know not to unapprove/reapprove something.

[lauriek334]

Regarding #3 - I've added a check to stop duplicate records from being created if one already exists.
regarding #1 - I've been mulling over this issue - If a change to the pickup date is made in the web form, when the form is "resubmitted", the check for an existing record is made in the 'arborcat_custom_pickup_request' table AND it would be possible to update an existing record with a new pickup date and/or new location