fix: catch reaction invalid emoji errors

Author: Dragory

backend/src/plugins/AutoReactions/events/AddReactionsEvt.ts

@@ -1,6 +1,6 @@
 import { GuildTextBasedChannel, PermissionsBitField } from "discord.js";
 import { AutoReaction } from "../../../data/entities/AutoReaction.js";
-import { isDiscordAPIError } from "../../../utils.js";
+import { isDiscordAPIError, isDiscordJsTypeError } from "../../../utils.js";
 import { getMissingChannelPermissions } from "../../../utils/getMissingChannelPermissions.js";
 import { missingPermissionError } from "../../../utils/missingPermissionError.js";
 import { readChannelPermissions } from "../../../utils/readChannelPermissions.js";
@@ -53,7 +53,12 @@ export const AddReactionsEvt = autoReactionsEvt({
       try {
         await message.react(reaction);
       } catch (e) {
-        if (isDiscordAPIError(e)) {
+        if (isDiscordJsTypeError(e)) {
+          const logs = pluginData.getPlugin(LogsPlugin);
+          logs.logBotAlert({
+            body: `Could not apply auto-reactions in <#${channel.id}> for message \`${message.id}\`: ${e.message}.`,
+          });
+        } else if (isDiscordAPIError(e)) {
           const logs = pluginData.getPlugin(LogsPlugin);
           if (e.code === 10008) {
             logs.logBotAlert({

backend/src/plugins/ReactionRoles/util/applyReactionRoleReactionsToMessage.ts

@@ -1,7 +1,7 @@
 import { Snowflake } from "discord.js";
 import { GuildPluginData } from "vety";
 import { ReactionRole } from "../../../data/entities/ReactionRole.js";
-import { isDiscordAPIError, sleep } from "../../../utils.js";
+import { isDiscordAPIError, isDiscordJsTypeError, sleep } from "../../../utils.js";
 import { LogsPlugin } from "../../Logs/LogsPlugin.js";
 import { ReactionRolesPluginType } from "../types.js";
 
@@ -72,7 +72,12 @@ export async function applyReactionRoleReactionsToMessage(
       await targetMessage.react(rawEmoji);
       await sleep(750); // Make sure we don't hit rate limits
     } catch (e) {
-      if (isDiscordAPIError(e)) {
+      if (isDiscordJsTypeError(e)) {
+        errors.push(e.message);
+        logs.logBotAlert({
+          body: `Error ${e.code} while applying reaction role reactions to ${channelId}/${messageId}: ${e.message}.`,
+        });
+      } else if (isDiscordAPIError(e)) {
         if (e.code === 10014) {
           pluginData.state.reactionRoles.removeFromMessage(messageId, rawEmoji);
           errors.push(`Unknown emoji: ${rawEmoji}`);

backend/src/utils.ts

@@ -3,6 +3,7 @@ import {
   ChannelType,
   Client,
   DiscordAPIError,
+  DiscordjsTypeError,
   EmbedData,
   EmbedType,
   Emoji,
@@ -83,6 +84,10 @@ export function isDiscordAPIError(err: Error | string): err is DiscordAPIError {
   return err instanceof DiscordAPIError;
 }
 
+export function isDiscordJsTypeError(err: unknown): err is DiscordjsTypeError {
+  return err instanceof DiscordjsTypeError;
+}
+
 // null | undefined -> undefined
 export function zNullishToUndefined<T extends z.ZodTypeAny>(
   type: T,