From ce6384f3293aac8d7d6c7336e7edcc4e67c6a3d9 Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Fri, 20 Feb 2026 20:42:54 +0000
Subject: [PATCH] feat(a11y): Add tooltips and dynamic descriptions for camera
 metrics

- Added `tooltipText` to frame time and bitrate indicators in `fragment_camera.xml`.
- Added new string resources for tooltips and verbose descriptions.
- Updated `CameraFragment.kt` to set `contentDescription` dynamically for better screen reader experience.
- Cleaned up duplicate attributes in `fragment_camera.xml`.

This improves discoverability for mouse/stylus users and provides semantic context for screen reader users.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
---
 .../android/scan3d/fragments/CameraFragment.kt       | 12 ++++++++----
 app/src/main/res/layout/fragment_camera.xml          | 11 ++++-------
 app/src/main/res/values/strings.xml                  |  6 ++++++
 3 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/app/src/main/java/com/samsung/android/scan3d/fragments/CameraFragment.kt b/app/src/main/java/com/samsung/android/scan3d/fragments/CameraFragment.kt
index 2385d99..123ff5a 100644
--- a/app/src/main/java/com/samsung/android/scan3d/fragments/CameraFragment.kt
+++ b/app/src/main/java/com/samsung/android/scan3d/fragments/CameraFragment.kt
@@ -106,10 +106,14 @@ class CameraFragment : Fragment() {
             intent.extras?.getParcelable<CamEngine.Companion.DataQuick>("dataQuick")?.apply {
                 activity?.runOnUiThread(Runnable {
                     // Stuff that updates the UI
-                    fragmentCameraBinding.qualFeedback?.text =
-                        " " + this.rateKbs + "kB/sec"
-                    fragmentCameraBinding.ftFeedback?.text =
-                        " " + this.ms + "ms"
+                    fragmentCameraBinding.qualFeedback?.let {
+                        it.text = " $rateKbs kB/sec"
+                        it.contentDescription = context.getString(R.string.bitrate_desc, rateKbs)
+                    }
+                    fragmentCameraBinding.ftFeedback?.let {
+                        it.text = " $ms ms"
+                        it.contentDescription = context.getString(R.string.frame_time_desc, ms)
+                    }
                 })
 
             }
diff --git a/app/src/main/res/layout/fragment_camera.xml b/app/src/main/res/layout/fragment_camera.xml
index 7eeaa62..4c8f189 100644
--- a/app/src/main/res/layout/fragment_camera.xml
+++ b/app/src/main/res/layout/fragment_camera.xml
@@ -74,7 +74,8 @@
                             android:layout_width="match_parent"
                             android:layout_height="wrap_content"
                             android:layout_gravity="start|center_vertical"
-                            android:layout_weight="1" />
+                            android:layout_weight="1"
+                            android:tooltipText="@string/frame_time_tooltip" />
 
                         <Button
                             android:id="@+id/buttonKill"
@@ -101,7 +102,6 @@
                         android:layout_marginTop="0pt"
                         android:layout_marginBottom="4pt"
                         android:background="#FFAA00"
-                        android:importantForAccessibility="no"
                         android:paddingTop="5pt" />
 
                 </TableRow>
@@ -158,7 +158,6 @@
                         android:layout_height="wrap_content"
                         android:labelFor="@+id/spinnerEncoding"
                         android:text="@string/encoding_label"
-                        android:labelFor="@+id/spinnerEncoding"
                         android:textAppearance="@style/TextAppearance.AppCompat.Medium" />
 
                     <Spinner
@@ -182,7 +181,6 @@
                         android:layout_height="wrap_content"
                         android:labelFor="@+id/spinnerCam"
                         android:text="@string/sensor_label"
-                        android:labelFor="@+id/spinnerCam"
                         android:textAppearance="@style/TextAppearance.AppCompat.Medium" />
 
                     <Spinner
@@ -205,7 +203,6 @@
                         android:layout_height="wrap_content"
                         android:labelFor="@+id/spinnerRes"
                         android:text="@string/resolution_label"
-                        android:labelFor="@+id/spinnerRes"
                         android:textAppearance="@style/TextAppearance.AppCompat.Medium" />
 
                     <Spinner
@@ -230,7 +227,6 @@
                         android:layout_gravity="center_vertical"
                         android:labelFor="@+id/spinnerQua"
                         android:text="@string/quality_label"
-                        android:labelFor="@+id/spinnerQua"
                         android:textAppearance="@style/TextAppearance.AppCompat.Medium" />
 
                     <LinearLayout
@@ -249,7 +245,8 @@
                             android:layout_width="wrap_content"
                             android:layout_height="wrap_content"
                             android:textColor="@color/colorPrimary"
-                            android:textSize="12sp" />
+                            android:textSize="12sp"
+                            android:tooltipText="@string/bitrate_tooltip" />
                     </LinearLayout>
 
                 </TableRow>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index bc53eb5..0f79b68 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -39,4 +39,10 @@
     <string name="stop_confirmation_message">This will stop the camera stream and close the application.</string>
     <string name="stop_confirmation_positive">Stop</string>
     <string name="stop_confirmation_negative">Cancel</string>
+
+    <!-- Feedback Tooltips and Content Descriptions -->
+    <string name="frame_time_tooltip">Frame latency</string>
+    <string name="bitrate_tooltip">Data transfer rate</string>
+    <string name="frame_time_desc">%1$d milliseconds latency</string>
+    <string name="bitrate_desc">%1$d kilobytes per second</string>
 </resources>