From 42cf99080298f2de34ebf1ba55fc1e040b7f3619 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Wed, 2 Nov 2022 07:29:07 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- .../onnx/onnx/backend/test/runner/__init__.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/Inference/parsers/onnx/third_party/onnx/onnx/backend/test/runner/__init__.py b/Inference/parsers/onnx/third_party/onnx/onnx/backend/test/runner/__init__.py index a3d9433a..98b8f270 100644 --- a/Inference/parsers/onnx/third_party/onnx/onnx/backend/test/runner/__init__.py +++ b/Inference/parsers/onnx/third_party/onnx/onnx/backend/test/runner/__init__.py @@ -191,7 +191,26 @@ def download_model(cls, model_test, model_dir, models_dir): # type: (TestCase, urlretrieve(model_test.url, download_file.name) print('Done') with tarfile.open(download_file.name) as t: - t.extractall(models_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(t, models_dir) except Exception as e: print('Failed to prepare data for model {}: {}'.format( model_test.model_name, e))