Skip to content

Can't disable facts on zpe.nodegrid.managed_devices module #70

@m-hau

Description

@m-hau

The zpe.nodegrid.managed_devices module has a parameter called facts, which needs to be a boolean, is required and defaults to False.

In the subsequent option execution check, that parameter is checked using is not None, and because it is a required parameter (aka it can't be None) this check will always succeed and collect the facts. Setting it to True or False makes no difference.

I found this issue because of #65 I was using verbose mode most of the time, and collecting the facts produces a lot of output which I wanted to reduce (but couldn't).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions