Skip to content

Commit 3bea6ad

Browse files
committed
fix: close buffer after tests
1 parent 20cf632 commit 3bea6ad

1 file changed

Lines changed: 18 additions & 9 deletions

File tree

hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/codec/TestNSSummaryCodec.java

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,12 @@ public void testCodecBufferRoundTrip() throws Exception {
4040
NSSummary original = createTestNSSummary();
4141

4242
CodecBuffer buffer = codec.toCodecBuffer(original, CodecBuffer.Allocator.DIRECT);
43-
NSSummary decoded = codec.fromCodecBuffer(buffer);
44-
45-
assertNSSummaryEquals(original, decoded);
43+
try {
44+
NSSummary decoded = codec.fromCodecBuffer(buffer);
45+
assertNSSummaryEquals(original, decoded);
46+
} finally {
47+
buffer.close();
48+
}
4649
}
4750

4851
@Test
@@ -52,9 +55,12 @@ public void testCodecBufferEmptyDirectory() throws Exception {
5255
original.setParentId(42L);
5356

5457
CodecBuffer buffer = codec.toCodecBuffer(original, CodecBuffer.Allocator.DIRECT);
55-
NSSummary decoded = codec.fromCodecBuffer(buffer);
56-
57-
assertNSSummaryEquals(original, decoded);
58+
try {
59+
NSSummary decoded = codec.fromCodecBuffer(buffer);
60+
assertNSSummaryEquals(original, decoded);
61+
} finally {
62+
buffer.close();
63+
}
5864
}
5965

6066
@Test
@@ -78,9 +84,12 @@ public void testCodecBufferLargeDirectory() throws Exception {
7884
original.setFileSizeBucket(buckets);
7985

8086
CodecBuffer buffer = codec.toCodecBuffer(original, CodecBuffer.Allocator.DIRECT);
81-
NSSummary decoded = codec.fromCodecBuffer(buffer);
82-
83-
assertNSSummaryEquals(original, decoded);
87+
try {
88+
NSSummary decoded = codec.fromCodecBuffer(buffer);
89+
assertNSSummaryEquals(original, decoded);
90+
} finally {
91+
buffer.close();
92+
}
8493
}
8594

8695
private NSSummary createTestNSSummary() {

0 commit comments

Comments
 (0)