refactor: add comprehensive runTest in TestKeyPrefixContainerCodec

Author: YutaLin

hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/KeyPrefixContainerCodec.java

@@ -44,7 +44,7 @@ public final class KeyPrefixContainerCodec
   private static final String KEY_DELIMITER = "_";
   private static final byte[] KEY_DELIMITER_BYTES = KEY_DELIMITER.getBytes(UTF_8);
   private static final ByteBuffer KEY_DELIMITER_BUFFER = ByteBuffer.wrap(KEY_DELIMITER_BYTES).asReadOnlyBuffer();
-  private static final int LONG_SERIALIZED_SIZE = KEY_DELIMITER_BYTES.length + Long.BYTES;
+  public static final int LONG_SERIALIZED_SIZE = KEY_DELIMITER_BYTES.length + Long.BYTES;
 
   public static Codec<KeyPrefixContainer> get() {
     return INSTANCE;

hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/spi/impl/TestKeyPrefixContainerCodec.java

@@ -33,29 +33,12 @@ public class TestKeyPrefixContainerCodec {
 
   private final Codec<KeyPrefixContainer> codec = KeyPrefixContainerCodec.get();
 
-  @Test
-  public void testKeyPrefixVersionAndContainer() throws Exception {
-    KeyPrefixContainer original = KeyPrefixContainer.get("testKey", 123L, 456L);
-    testCodecBuffer(original);
-  }
-
-  @Test
-  public void testEmptyKeyPrefix() throws Exception {
-    KeyPrefixContainer original = KeyPrefixContainer.get("", 0L, 0L);
-    testCodecBuffer(original);
-  }
-
   @Test
   public void testKeyPrefixWithDelimiter() throws Exception {
-    KeyPrefixContainer original = KeyPrefixContainer.get("test_key_with_underscores", 789L, 101112L);
-    testCodecBuffer(original);
-  }
-
-  @Test
-  public void testLongKeyPrefix() throws Exception {
-    KeyPrefixContainer originalWithBoth = KeyPrefixContainer.get(
-        "test___________________________________Key", 123L, 456L);
-    testCodecBuffer(originalWithBoth);
+    runTest("testKey", 123L, 456L);
+    runTest("test_key_with_underscores", 789L, 101112L);
+    runTest("test___________________________________Key", 1L, 2L);
+    runTest("", 0L, 0L);
   }
 
   @Test
@@ -68,19 +51,42 @@ public void testTypeClass() {
     assertEquals(KeyPrefixContainer.class, codec.getTypeClass());
   }
 
-  private void testCodecBuffer(KeyPrefixContainer original) throws Exception {
+  void runTest(String keyPrefix, long version, long containerId) throws Exception {
+    final KeyPrefixContainer original = KeyPrefixContainer.get(keyPrefix, version, containerId);
+    final KeyPrefixContainer keyAndVersion = KeyPrefixContainer.get(keyPrefix, version);
+    final KeyPrefixContainer keyOnly = KeyPrefixContainer.get(keyPrefix);
+
+    final CodecBuffer.Allocator allocator = CodecBuffer.Allocator.getHeap();
+    try (CodecBuffer originalBuffer = codec.toCodecBuffer(original, allocator);
+         CodecBuffer keyOnlyBuffer = codec.toCodecBuffer(keyOnly, allocator);
+         CodecBuffer keyAndVersionBuffer = codec.toCodecBuffer(keyAndVersion, allocator)) {
+      assertEquals(original, codec.fromCodecBuffer(originalBuffer));
+      assertTrue(originalBuffer.startsWith(keyAndVersionBuffer));
+      assertTrue(originalBuffer.startsWith(keyOnlyBuffer));
+
+      final byte[] originalBytes = assertCodecBuffer(original, originalBuffer);
+      assertEquals(original, codec.fromPersistedFormat(originalBytes));
+
+      final byte[] keyAndVersionBytes = assertCodecBuffer(keyAndVersion, keyAndVersionBuffer);
+      assertPrefix(originalBytes.length - KeyPrefixContainerCodec.LONG_SERIALIZED_SIZE,
+          originalBytes, keyAndVersionBytes);
+
+      final byte[] keyOnlyBytes = assertCodecBuffer(keyOnly, keyOnlyBuffer);
+      assertPrefix(originalBytes.length - 2 * KeyPrefixContainerCodec.LONG_SERIALIZED_SIZE,
+          originalBytes, keyOnlyBytes);
+    }
+  }
 
-    final CodecBuffer codecBuffer = codec.toCodecBuffer(
-        original, CodecBuffer.Allocator.getHeap());
-    final KeyPrefixContainer fromBuffer = codec.fromCodecBuffer(codecBuffer);
+  static void assertPrefix(int expectedLength, byte[] array, byte[] prefix) {
+    assertEquals(expectedLength, prefix.length);
+    for (int i = 0; i < prefix.length; i++) {
+      assertEquals(array[i], prefix[i]);
+    }
+  }
 
+  byte[] assertCodecBuffer(KeyPrefixContainer original, CodecBuffer buffer) throws Exception {
     final byte[] bytes = codec.toPersistedFormat(original);
-    assertArrayEquals(bytes, codecBuffer.getArray());
-
-    codecBuffer.release();
-    assertEquals(original, fromBuffer);
-
-    KeyPrefixContainer fromPersisted = codec.fromPersistedFormat(bytes);
-    assertEquals(original, fromPersisted);
+    assertArrayEquals(bytes, buffer.getArray());
+    return bytes;
   }
 }