From 6fad9e09cd66b485353804a9d0a514a8dcb4a8f5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Josu=C3=A9=20Tille?= <josue@tille.ch>
Date: Fri, 13 Feb 2026 18:18:54 +0100
Subject: [PATCH 1/2] Fix parsing version from manifest

* Currently the way to parse the version could bring false positive when there are for instance a go versin field in the manifest. So we need to use a correct parser.
---
 lib/common.sh | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lib/common.sh b/lib/common.sh
index 0a40172..fa47bf6 100644
--- a/lib/common.sh
+++ b/lib/common.sh
@@ -377,7 +377,12 @@ function fetch_package_to_test() {
     git -C "$package_path" rev-parse HEAD > "$TEST_CONTEXT/commit"
     git -C "$package_path" show --no-patch --format=%ct HEAD > "$TEST_CONTEXT/commit_timestamp"
 
-    grep "^\s*version\s*=" "$package_path/manifest.toml" | cut -d= -f2 | tr -d '" ' > "$TEST_CONTEXT/app_version"
+    python3 -c "
+import sys
+import toml
+with open(sys.argv[1], 'r') as f:
+    print(toml.load(f)['version'])
+    " "$package_path/manifest.toml" > "$TEST_CONTEXT/app_version"
 
     # Check if the package directory is really here.
     if [ ! -d "$package_path" ]; then

From 7aa20ae23b164b1e7caf1d92f1b53d46189e80ee Mon Sep 17 00:00:00 2001
From: Salamandar <6552989+Salamandar@users.noreply.github.com>
Date: Sat, 14 Feb 2026 13:39:10 +0100
Subject: [PATCH 2/2] Apply suggestion from @Salamandar

---
 lib/common.sh | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/lib/common.sh b/lib/common.sh
index fa47bf6..e10c5ce 100644
--- a/lib/common.sh
+++ b/lib/common.sh
@@ -377,12 +377,8 @@ function fetch_package_to_test() {
     git -C "$package_path" rev-parse HEAD > "$TEST_CONTEXT/commit"
     git -C "$package_path" show --no-patch --format=%ct HEAD > "$TEST_CONTEXT/commit_timestamp"
 
-    python3 -c "
-import sys
-import toml
-with open(sys.argv[1], 'r') as f:
-    print(toml.load(f)['version'])
-    " "$package_path/manifest.toml" > "$TEST_CONTEXT/app_version"
+    python3 -c "import sys; import toml; f = open(sys.argv[1], 'r'); print(toml.load(f)['version'])" \
+        "$package_path/manifest.toml" > "$TEST_CONTEXT/app_version"
 
     # Check if the package directory is really here.
     if [ ! -d "$package_path" ]; then