Extra / in CURL when deploying options

[jimusik]

Similar Issue to dvankevich - all the options are getting filtered with a / before the option is set.

Line 528:

"$curl" "${curl_options[@]}" --request GET --url "$url/api/$endpoint${id:+/}$id${target:+/}$target"

should be:

"$curl" "${curl_options[@]}" --request GET --url "$url/api/$endpoint${id:+}$id${target:+/}$target"

Once corrected, I'm able to properly set options like count and offset.

[PinkFreud]

This doesn't quite work. If you run bs under bash -x, you'll see that specifying any options causes those options to be incorrectly assigned to the id parameter:

...
+ getopts c:o:s:f: OPTION
+ case "$OPTION" in
+ query='?offset=100'
+ getopts c:o:s:f: OPTION
+ get users '?offset=100'
+ endpoint=users
+ id='?offset=100'
+ target=
+ shift 3
+ curl -s --http1.1 --header 'Authorization: Token aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa:bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' --request GET --url 'https://my.bookstack/api/users/?offset=100'

Indeed, your fix breaks specifying id with -i for read, update, etc requests.

I'm not quite sure what the proper fix is here as of yet - I'm still thinking it over.

[PinkFreud]

I've fixed this in my fork, and created a PR in this repo to have it merged. It looks like this repo might be abandoned, so I'm not holding my breath for it to be applied, but perhaps I'll be surprised.

#6