Question about interfaces of `RadarStackedHourglass` class for `MaxVIT2` and `RODNetHGwIDCN_2d` networks

[kathy-lee]

Hi @YahiDar ,
thank you for sharing with the great work with us! I have two small questions both about the interfaces of RadarStackedHourglass class for MaxVIT2 and RODNetHGwIDCN_2d networks, can you help me to make it clear please?

1. At line 25 of /rodnet/models/rodnet_hgwi_v2_2d.py file(https://github.com/YahiDar/RadarFormer/blob/02c96ae62a56164fafc653ca04f3813df58e1a3f/rodnet/models/rodnet_hgwi_v2_2d.py#L25C15-L25C15), the initialization of RadarStackedHourglass seems missing a parameter win_size which is demanded by its class definition.
2. At line 42 of /rodnet/models/MaxVIT2.py file(https://github.com/YahiDar/RadarFormer/blob/02c96ae62a56164fafc653ca04f3813df58e1a3f/rodnet/models/MaxVIT2.py#L42C16-L42C16), RadarStackedHourglass is initialized with a parameter conv_op which doesn't exist in the interface of its class definiton.
   Please correct me if I'm wrong. Many thanks for your help in advance!

[YahiDar]

Hi,

The parameters you mentioned:
1- win_size is used only if mnet_cfg is set to a value (i.e. not None). The configure file has them, which is passed through the functions/classes. if you had edited anything that resulted in mnet_cfg to be seen as none, it will use the 'else' statement in line 25. otherwise it should default to line 21 which has win_size.

2- conv_op is used as 3D convolution. The alternative is the DeformConvPack3D which requires certain C++ libraries that are attached in the original RODNet repository. If you use the correct configurations, you should pass the dcn = False from the config files accordingly.

[kathy-lee]

Hi @YahiDar , thank you for explanation! I'm afraid these two else conditions which I mentioned will pop out error, as it doesn't match with the RadarStackedHourglass class interfaces you designed in rodnet/models/backbones/hgwi_2d.py and rodnet/models/backbones/MaxVIT2.py, the first one demeands 'win_size' to be assigned, the second one doesn't have 'conv_op' in the interface.

[YahiDar]

Hi,

I have pushed an edit that might fix the problem you are having.
If not, I advise that you try to figure out the necessary configurations to make the model run as described. If conv_op is giving you trouble, you can edit the paramter completely out and replace it with a Conv3D within the code wherever it applies.
This also applies to the win_size parameter as well.

Thank you