Skip to content

CMake configuration is too platform-dependent and potentially broken #6

@JayFoxRox

Description

@JayFoxRox

This differentiates MSVC and non-MSVC, when, for the most part, it probably shouldn't have to be this way:

if(MSVC) # assumes vcpkg
find_package(jansson CONFIG REQUIRED)
find_package(PNG REQUIRED)
find_package(embree 3 REQUIRED)
find_package(assimp CONFIG REQUIRED)
link_directories(${EMBREE_ROOT_DIR}/lib)
set(JANSSON jansson::jansson)
add_definitions(/D_USE_MATH_DEFINES /DNOMINMAX /wd4305 /wd4244 /wd4996)
else()
set(JANSSON jansson)
endif()

Most (all?) packages are probably also required on non-MSVC.
This will hinder portability.


In addition, none of those packges are actually used / linked within this projects CMakeLists.txt.

I assume that the dependencies will take care of linking them, but in that case, this project shouldn't even have to be aware of these libraries (instead, the dependency should pull them in).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions