-
Notifications
You must be signed in to change notification settings - Fork 7
Open
Description
This differentiates MSVC and non-MSVC, when, for the most part, it probably shouldn't have to be this way:
Lines 9 to 19 in 3dbbce0
| if(MSVC) # assumes vcpkg | |
| find_package(jansson CONFIG REQUIRED) | |
| find_package(PNG REQUIRED) | |
| find_package(embree 3 REQUIRED) | |
| find_package(assimp CONFIG REQUIRED) | |
| link_directories(${EMBREE_ROOT_DIR}/lib) | |
| set(JANSSON jansson::jansson) | |
| add_definitions(/D_USE_MATH_DEFINES /DNOMINMAX /wd4305 /wd4244 /wd4996) | |
| else() | |
| set(JANSSON jansson) | |
| endif() |
Most (all?) packages are probably also required on non-MSVC.
This will hinder portability.
In addition, none of those packges are actually used / linked within this projects CMakeLists.txt.
I assume that the dependencies will take care of linking them, but in that case, this project shouldn't even have to be aware of these libraries (instead, the dependency should pull them in).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels