From 618ee1b581ad791ce1b42db1af2372a1cba8a8b9 Mon Sep 17 00:00:00 2001 From: Bernie Reiter Date: Wed, 21 Sep 2022 13:58:54 +0200 Subject: [PATCH 1/4] CI: Don't run NPM Test in Windows --- .github/workflows/test-npm.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-npm.yml b/.github/workflows/test-npm.yml index 142d428ae0b8d..4b1f1a107689c 100644 --- a/.github/workflows/test-npm.yml +++ b/.github/workflows/test-npm.yml @@ -58,7 +58,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ ubuntu-latest, windows-latest ] + os: [ ubuntu-latest ] steps: - name: Checkout repository From dcaa8cd8726010fc7f938ebe93c4761ede4420dc Mon Sep 17 00:00:00 2001 From: Bernie Reiter Date: Wed, 21 Sep 2022 15:17:03 +0200 Subject: [PATCH 2/4] continue-on-error Co-authored-by: Jon Desrosiers --- .github/workflows/test-npm.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test-npm.yml b/.github/workflows/test-npm.yml index 4b1f1a107689c..8d20f34a73c3a 100644 --- a/.github/workflows/test-npm.yml +++ b/.github/workflows/test-npm.yml @@ -55,6 +55,7 @@ jobs: runs-on: ${{ matrix.os }} timeout-minutes: 20 if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }} + continue-on-error: ${{ matrix.os == 'windows-latest' }} strategy: fail-fast: false matrix: From 41d6863dfe9d53d253e8fae53e25685f0ad839ca Mon Sep 17 00:00:00 2001 From: Bernie Reiter Date: Wed, 21 Sep 2022 15:17:16 +0200 Subject: [PATCH 3/4] Add back windows-latest Co-authored-by: Jon Desrosiers --- .github/workflows/test-npm.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-npm.yml b/.github/workflows/test-npm.yml index 8d20f34a73c3a..b8fa3293ebc23 100644 --- a/.github/workflows/test-npm.yml +++ b/.github/workflows/test-npm.yml @@ -59,7 +59,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ ubuntu-latest ] + os: [ ubuntu-latest, windows-latest ] steps: - name: Checkout repository From 0714670b6a729f95f704f3c91b51c5219e93580f Mon Sep 17 00:00:00 2001 From: Jon Desrosiers Date: Wed, 21 Sep 2022 09:51:13 -0400 Subject: [PATCH 4/4] Try a different expression for `continue-on-error`. --- .github/workflows/test-npm.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-npm.yml b/.github/workflows/test-npm.yml index b8fa3293ebc23..89b83f46faf8b 100644 --- a/.github/workflows/test-npm.yml +++ b/.github/workflows/test-npm.yml @@ -55,7 +55,7 @@ jobs: runs-on: ${{ matrix.os }} timeout-minutes: 20 if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }} - continue-on-error: ${{ matrix.os == 'windows-latest' }} + continue-on-error: ${{ matrix.os == 'windows-latest' && true }} strategy: fail-fast: false matrix: