Query Loop: please don't treat template parts & synced patterns as singular

[Andrew-Starr]

Description

Query loop is automatically changing the inherit property from true to false, when in a singular object (post, page custom etc) but this also means that template parts and synced patterns are regarded as singular.

I can understand the reasoning behind this as a query loop placed in a page cannot inherit the query, but this is causing issues when for example an archive template contains either a synced pattern or template part that in turn contains the query loop. In this case the inherit attribute is auto changed to false, and is breaking the display of the query loop.

Step-by-step reproduction instructions

Place a query loop with inherit set to true, inside either a template part or a synced pattern.
Place the template part or synced pattern inside the archive template.
Check the front end and see that the query is inherited perfectly OK (only posts from correct category or tag are displayed).

This next part is where the weirdness happens:
Edit the template part or synced pattern, e.g. just make a small change to the post title color or font size, and save the part/pattern.
View the frontend and notice that the query now doesn't inherit the correct query.

What is happening is that the query loop inherit:true is auto changed to inherit:false but it doesn't trigger a "save changes " prompt, so everything appears to work correctly, until you make an edit, and then the auto changed inherit:false is saved along with the other changes.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[Andrew-Starr]

Similar issue: #67252

It seems this is not a bug, but was introduced in core WP 6.8 - #65820 - and then will be reverted in the upcoming 6.8.2(?) release - #69698

So, any parts or synced patterns added before 6.8 and then edited between 6.8 and 6.8.2 will be broken, with the user needing to change the inherit attr back to true - or in the meantime switch to code editor and manually change it but remember that the next time they load that pattern in the editor the inherit value will be auto changed again.

I'd like to add that I don't regard it as a good idea to auto change things like this without communicating to the user that the change has been made.

[Mamaduka]

Yes, this was a bug that was fixed via #69698.

I'd like to add that I don't regard it as a good idea to auto change things like this without communicating to the user that the change has been made.

Similar changes always come from good intentions; unfortunately, we missed some edge cases. However, I fully agree with this, and I even highlighted similar concerns in the PR.

I'm don't think anything else can be done here. The bug will be fixed in WordPress 6.8.2, and users may need to update their Query blocks accordingly.

Should we close this as fixed?

[Andrew-Starr]

Thanks @Mamaduka

After posting this issue, it took me a while to find where this was introduced, and I also somehow missed it going into WP 6.8

I'll close it as not needed.

[Mamaduka]

Thanks, @Andrew-Starr!