Skip to content

LD app sent obsolete VehicleLandDetectedMsg(AltMax) when the battery status was changed #342

@ynielson

Description

@ynielson

When the LD app received Wakeup MID and detected a changed Battery Status(Warning: PX4_BATTERY_WARNING_LOW),
It sent the previous "VehicleLandDetectedMsg.AltMax" value which was "10000.000000",
though it calculated changed "altitude_max"(7500.000000) in this case.

It compared the Max Altitude status between the previous "VehicleLandDetectedMsg.AltMax" and the "prev_altitude_max",
instead of using changed "altitude_max".
Unless there is an intended reason, this may be an issue.

The app sent the changed value in the next VehicleLandDetectedMsg.AltMax,
but depending on how often the message is to be sent and how often the app receives the changed data messages
it may cause issues.

  • Test case: Test_LD_Execute_Landed()
    ld_Execute_Landed_AltMax_1_2023-03-24 13-03-17
    ld_Execute_Landed_AltMax_2_2023-03-24 14-38-40

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions