From 7775be8050a6c7552b5eeace77f3ff8c3653485c Mon Sep 17 00:00:00 2001 From: Janet Davis Date: Tue, 14 May 2019 14:57:13 -0700 Subject: [PATCH 1/3] Added grading rubric --- {project-overview => project-6}/README.md | 0 {project-overview => project-6}/UML.png | Bin .../git-commands.txt | 0 project-6/rubric.md | 61 ++++++++++++++++++ 4 files changed, 61 insertions(+) rename {project-overview => project-6}/README.md (100%) rename {project-overview => project-6}/UML.png (100%) rename {project-overview => project-6}/git-commands.txt (100%) create mode 100644 project-6/rubric.md diff --git a/project-overview/README.md b/project-6/README.md similarity index 100% rename from project-overview/README.md rename to project-6/README.md diff --git a/project-overview/UML.png b/project-6/UML.png similarity index 100% rename from project-overview/UML.png rename to project-6/UML.png diff --git a/project-overview/git-commands.txt b/project-6/git-commands.txt similarity index 100% rename from project-overview/git-commands.txt rename to project-6/git-commands.txt diff --git a/project-6/rubric.md b/project-6/rubric.md new file mode 100644 index 0000000..e54f4ee --- /dev/null +++ b/project-6/rubric.md @@ -0,0 +1,61 @@ +# GRADE: 48/48 + +## Functional and implementation requirements: 26/26 points total + +### Menu: 2/2 points + +Earned|Possible|Requirement | Comments +------|--------|-------------|- +1|1|Add **Undo** and **Redo** menu items to the **Edit** menu. The **Undo** menu item should have a keyboard equivalent of Ctrl/Cmd-Z. The **Redo** menu item should have a keyboard equivalent Ctrl/Cmd-Shift-Z. +1|1|Put a separator between them and the other **Edit** menu items. +0|0|**Undo** is disabled when the program starts and when all actions have been undone; it is enabled when the first action is taken. | _Addressed in the Project 7 rubric_ +0|0|**Redo** is disabled unless there is an action to redo. +0|0|**Group** is disabled when there are fewer than two items selected. +0|0|**Ungroup** is disabled when the selection is not (or does not contain) a gesture. +0|0|**Delete** is disabled when nothing is selected. +0|0|**Play** is disabled when there are no notes. +0|0|**Stop** is disabled when the composition is not playing. + +### Undo/redo operations: 16/16 points + +1 pt each|Undo|Redo +---------|----|---- +Add | +Select | +Delete | +Move | +Stretch | +Group | +Ungroup | + +Earned|Possible|Requirement +------|--------|------------ +2|2|If note bars are deleted, edited, or selected as a group, for example, by using the **Select All** menu item, then an undo operation should affect all of the note bars. + +### Undo/redo stack: 8/8 points + +Earned|Possible|Requirement +------|--------|------------ +4|4|The user should be allowed to undo actions repeatedly, all the way back to the original blank composition pane when the application was first started. +4|4|Similarly, if a sequence of undo actions was performed, then the user should be allowed to redo the whole sequence. + +### No regressions - 0/0 points + +All prior requirements are met, unless they have been superseded by new requirements. (I will not replicate points taken off in Project 5.) _Not assessed to avoid double jeopardy_ + +## Release - 2/2 points +Earned|Possible|Requirement +------|--------|------------ +2|2| The release is tagged as project-6-release. + +## Reflection and elegance - 20/20 points + +As promised, I am not looking closely at your code for this iteration, only spot-checking. + +* 4/4 UML diagram is accurate and complete. +* 2/2 New classes/methods are reasonably self-explanatory. +* 3/3 Design overview addresses strategy for Undo/Redo. +* 2/2 Design overview addresses strategy for disabling/enabling menu items. +* 6/6 Assessment of what is elegant and what is not thoughtfully addresses object-oriented design principles. +* 2/2 Velocity is presented. +* 1/1 Team retrospective is presented. From 9b698f468d54c567151527be4469487f41d6658b Mon Sep 17 00:00:00 2001 From: Janet Davis Date: Tue, 14 May 2019 15:19:06 -0700 Subject: [PATCH 2/3] Commented and scored --- project-6/rubric.md | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/project-6/rubric.md b/project-6/rubric.md index e54f4ee..6d24583 100644 --- a/project-6/rubric.md +++ b/project-6/rubric.md @@ -1,6 +1,6 @@ -# GRADE: 48/48 +# GRADE: 48/48 -## Functional and implementation requirements: 26/26 points total +## Functional and implementation requirements: 28/28 points total ### Menu: 2/2 points @@ -16,28 +16,29 @@ Earned|Possible|Requirement | Comments 0|0|**Play** is disabled when there are no notes. 0|0|**Stop** is disabled when the composition is not playing. -### Undo/redo operations: 16/16 points +### Undo/redo operations: 18/18 points 1 pt each|Undo|Redo ---------|----|---- -Add | -Select | -Delete | -Move | -Stretch | -Group | -Ungroup | +Add |1|1 +Select |1|1 +Delete |1|1 +Move |1|1 +Stretch |1|1 +Group |1|1 +Ungroup |1|1 Earned|Possible|Requirement ------|--------|------------ -2|2|If note bars are deleted, edited, or selected as a group, for example, by using the **Select All** menu item, then an undo operation should affect all of the note bars. +4|4|If note bars are deleted, edited, or selected as a group, for example, by using the **Select All** menu item, then an undo operation should affect all of the note bars. ### Undo/redo stack: 8/8 points Earned|Possible|Requirement ------|--------|------------ 4|4|The user should be allowed to undo actions repeatedly, all the way back to the original blank composition pane when the application was first started. -4|4|Similarly, if a sequence of undo actions was performed, then the user should be allowed to redo the whole sequence. +2|2|Similarly, if a sequence of undo actions was performed, then the user should be allowed to redo the whole sequence. +2|2|Taking a new action should clear the redo stack. ### No regressions - 0/0 points @@ -48,14 +49,14 @@ Earned|Possible|Requirement ------|--------|------------ 2|2| The release is tagged as project-6-release. -## Reflection and elegance - 20/20 points +## Reflection and elegance - 18/18 points As promised, I am not looking closely at your code for this iteration, only spot-checking. * 4/4 UML diagram is accurate and complete. -* 2/2 New classes/methods are reasonably self-explanatory. +* 1/1 New classes/methods are reasonably self-explanatory. * 3/3 Design overview addresses strategy for Undo/Redo. * 2/2 Design overview addresses strategy for disabling/enabling menu items. -* 6/6 Assessment of what is elegant and what is not thoughtfully addresses object-oriented design principles. -* 2/2 Velocity is presented. -* 1/1 Team retrospective is presented. +* 6/6 Assessment of what is elegant and what is not thoughtfully addresses object-oriented design principles. | _I like that you thought about implications for change (project 7 requiremnets)._ +* 1/1 Velocity is presented. +* 1/1 Team retrospective is presented. | _Thanks for your thoughts! This was a really good reflection - sorry I did not get you feedback earlier._ From c436112b1d98fe6823d586dbbf090e3882c1e18f Mon Sep 17 00:00:00 2001 From: Janet Davis Date: Tue, 14 May 2019 15:29:09 -0700 Subject: [PATCH 3/3] Updated points to match rubric --- project-6/rubric.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/project-6/rubric.md b/project-6/rubric.md index 6d24583..ef932b0 100644 --- a/project-6/rubric.md +++ b/project-6/rubric.md @@ -54,9 +54,8 @@ Earned|Possible|Requirement As promised, I am not looking closely at your code for this iteration, only spot-checking. * 4/4 UML diagram is accurate and complete. -* 1/1 New classes/methods are reasonably self-explanatory. * 3/3 Design overview addresses strategy for Undo/Redo. -* 2/2 Design overview addresses strategy for disabling/enabling menu items. +* 3/3 Design overview addresses strategy for disabling/enabling menu items. * 6/6 Assessment of what is elegant and what is not thoughtfully addresses object-oriented design principles. | _I like that you thought about implications for change (project 7 requiremnets)._ * 1/1 Velocity is presented. * 1/1 Team retrospective is presented. | _Thanks for your thoughts! This was a really good reflection - sorry I did not get you feedback earlier._