`MigrateMediaToAssetsForTextMediaCe` is missing a condition for leftJoin

[julianhofmann]

In \TYPO3\CMS\v76\Install\Updates\MigrateMediaToAssetsForTextMediaCe::executeUpdate() there's the forth parameter in leftJoin missing. The join is processed without any condition.

https://github.com/WapplerSystems/core_upgrader/blob/release/v12/Classes/Updates/v76/MigrateMediaToAssetsForTextMediaCe.php#L90

Should be:

->leftJoin('sys_file_reference','tt_content','tt_content',
    $updateQueryBuilder->expr()->and(
        $updateQueryBuilder->expr()->eq(
            'uid_foreign', $updateQueryBuilder->quoteIdentifier('tt_content.uid')
        ),
        $updateQueryBuilder->expr()->eq(
            'tablenames', $updateQueryBuilder->createNamedParameter('tt_content', \PDO::PARAM_STR)
        ),
        $updateQueryBuilder->expr()->eq(
            'fieldname', $updateQueryBuilder->createNamedParameter('media', \PDO::PARAM_STR)
        ),
    )
)

[echavaillaz]

Even with the forth parameter, I got a fatal:

Column not found: 1054 Unknown column 'tt_content.CType' in 'where clause'

[julianhofmann]

@echavaillaz, since it is a upgradewizard from v7, one way may be to deactivate the old wizards.
In my case, it was an upgrade from v9 to v12. We simply removed the wizards from v7, v8 and v9 in Services.yaml.
This doesn't actually fix the problem, but it worked for me.

[thomaskieslich]

Just updated the code with this and it works for me:

    /**
     * Performs the database update if old mediafile references are available
     *
     * @return bool
     */
    public function executeUpdate(): bool
    {
        $connection = GeneralUtility::makeInstance(ConnectionPool::class)->getConnectionForTable('sys_file_reference');

        // Update sys_file_reference records
        $updateQueryBuilder = $connection->createQueryBuilder();
        $updateQueryBuilder->update('sys_file_reference')
            ->where(
                $updateQueryBuilder->expr()->and(
                    $updateQueryBuilder->expr()->eq('tablenames', $updateQueryBuilder->createNamedParameter('tt_content')),
                    $updateQueryBuilder->expr()->eq('fieldname', $updateQueryBuilder->createNamedParameter('media'))
                )
            )
            ->set('fieldname', $updateQueryBuilder->createNamedParameter('assets'))
            ->executeStatement();

        // Update tt_content records
        $contentConnection = GeneralUtility::makeInstance(ConnectionPool::class)->getConnectionForTable('tt_content');
        $contentQueryBuilder = $contentConnection->createQueryBuilder();
        $contentQueryBuilder->update('tt_content')
            ->where(
                $contentQueryBuilder->expr()->and(
                    $contentQueryBuilder->expr()->eq('CType', $contentQueryBuilder->createNamedParameter('textmedia')),
                    $contentQueryBuilder->expr()->gt('media', $contentQueryBuilder->createNamedParameter(0, ParameterType::INTEGER))
                )
            )
            ->set('assets', 'media', false)
            ->set('media', 0)
            ->executeStatement();

        return true;
    }