From fabb8d5ce15c2d6ca01f394eacf29abcaeeaf9d9 Mon Sep 17 00:00:00 2001 From: ameaninglessname Date: Sat, 18 Oct 2025 16:35:35 +0800 Subject: [PATCH] Fixed: build error when making installed build --- .../Private/PropertyHistoryHandler.cpp | 6 +++++- .../PropertyHistory/Private/PropertyHistoryHandler.h | 8 +++++++- .../Private/PropertyHistoryModule.cpp | 11 +++++++---- .../Private/PropertyHistoryProcessor.h | 4 +++- .../Private/PropertyHistoryUtilities.h | 6 +++++- Source/PropertyHistory/Private/SPropertyHistory.cpp | 12 +++++++++--- Source/PropertyHistory/Private/SPropertyHistory.h | 4 +++- 7 files changed, 39 insertions(+), 12 deletions(-) diff --git a/Source/PropertyHistory/Private/PropertyHistoryHandler.cpp b/Source/PropertyHistory/Private/PropertyHistoryHandler.cpp index 8f9cac3..c494b11 100644 --- a/Source/PropertyHistory/Private/PropertyHistoryHandler.cpp +++ b/Source/PropertyHistory/Private/PropertyHistoryHandler.cpp @@ -10,6 +10,10 @@ #include "SourceControlOperations.h" #include "PropertyHistoryUtilities.h" #include "PropertyHistoryProcessor.h" +#include "Framework/Application/SlateApplication.h" +#include "Framework/Docking/TabManager.h" +#include "UObject/Package.h" +#include "Widgets/Docking/SDockTab.h" FPropertyHistoryHandler::FPropertyHistoryHandler(const FPropertyHistoryProcessor& Processor) : PropertyChain(Processor.Properties) @@ -355,4 +359,4 @@ void FPropertyHistoryHandler::AddError(const FString& NewError) { Error = NewError; } -} \ No newline at end of file +} diff --git a/Source/PropertyHistory/Private/PropertyHistoryHandler.h b/Source/PropertyHistory/Private/PropertyHistoryHandler.h index 15bbcb2..91fb897 100644 --- a/Source/PropertyHistory/Private/PropertyHistoryHandler.h +++ b/Source/PropertyHistory/Private/PropertyHistoryHandler.h @@ -5,7 +5,13 @@ #include "CoreMinimal.h" #include "StructUtils/PropertyBag.h" #include "PropertyHistoryProcessor.h" +#include "Async/Future.h" +#include "Containers/Ticker.h" +class IPropertyHandle; +class IDetailTreeNode; +class IPropertyRowGenerator; +class ISourceControlRevision; class ISourceControlState; class FDetailColumnSizeData; @@ -66,4 +72,4 @@ class FPropertyHistoryHandler void Tick(); void AddError(const FString& NewError); -}; \ No newline at end of file +}; diff --git a/Source/PropertyHistory/Private/PropertyHistoryModule.cpp b/Source/PropertyHistory/Private/PropertyHistoryModule.cpp index e1d9638..83077ed 100644 --- a/Source/PropertyHistory/Private/PropertyHistoryModule.cpp +++ b/Source/PropertyHistory/Private/PropertyHistoryModule.cpp @@ -13,8 +13,11 @@ #include "Editor/PropertyEditor/Private/PropertyHandleImpl.h" #include "Editor/PropertyEditor/Private/SDetailSingleItemRow.h" #include "Editor/PropertyEditor/Private/DetailRowMenuContextPrivate.h" +#include "Framework/Docking/TabManager.h" +#include "Widgets/Docking/SDockTab.h" DEFINE_PRIVATE_ACCESS(FPropertyNode, InstanceMetaData) + DEFINE_PRIVATE_ACCESS(SDetailsViewBase, DetailLayouts) DEFINE_PRIVATE_ACCESS(SDetailTableRowBase, OwnerTreeNode) DEFINE_PRIVATE_ACCESS_FUNCTION(SDetailSingleItemRow, GetPropertyNode); @@ -160,7 +163,7 @@ class FPropertyHistoryModule : public IModuleInterface } int32 ArrayIndex = -1; - LexFromString(ArrayIndex, Parts[2]); + Parts[2] = FString::Format(TEXT("%d"), {ArrayIndex}); Properties.Add({ Property, ArrayIndex }); NumAddedProperties++; @@ -172,7 +175,7 @@ class FPropertyHistoryModule : public IModuleInterface #if PROPERTY_HISTORY_ENGINE_VERSION >= 506 const TSharedPtr DetailsViewBase = StaticCastSharedPtr(Context->DetailsView.Pin()); #else - SDetailsViewBase* DetailsViewBase = reinterpret_cast(Context->DetailsView); + SDetailsViewBase* DetailsViewBase = reinterpret_cast(Context->DetailsView.Pin().Get()); #endif const TSharedPtr RootNode = INLINE_LAMBDA -> TSharedPtr { @@ -257,7 +260,7 @@ class FPropertyHistoryModule : public IModuleInterface #if PROPERTY_HISTORY_ENGINE_VERSION >= 506 Processor.DetailsView = Context->DetailsView.Pin(); #else - Processor.DetailsView = Context->DetailsView; + Processor.DetailsView = Context->DetailsView.Pin().Get(); #endif void* Container = nullptr; if (!Processor.Process(Container)) @@ -292,4 +295,4 @@ class FPropertyHistoryModule : public IModuleInterface } }; -IMPLEMENT_MODULE(FPropertyHistoryModule, PropertyHistory); \ No newline at end of file +IMPLEMENT_MODULE(FPropertyHistoryModule, PropertyHistory); diff --git a/Source/PropertyHistory/Private/PropertyHistoryProcessor.h b/Source/PropertyHistory/Private/PropertyHistoryProcessor.h index 8480d9a..b221399 100644 --- a/Source/PropertyHistory/Private/PropertyHistoryProcessor.h +++ b/Source/PropertyHistory/Private/PropertyHistoryProcessor.h @@ -5,6 +5,8 @@ #include "CoreMinimal.h" #include "PropertyHistoryUtilities.h" +class IDetailsView; +class UMaterialExpression; class UPreviewMaterial; class UMaterialEditorInstanceConstant; @@ -61,4 +63,4 @@ struct FPropertyHistoryProcessor private: UScriptStruct* TargetStampStruct = nullptr; bool bFetchMaterialParameterName = false; -}; \ No newline at end of file +}; diff --git a/Source/PropertyHistory/Private/PropertyHistoryUtilities.h b/Source/PropertyHistory/Private/PropertyHistoryUtilities.h index bd117b9..2ef9828 100644 --- a/Source/PropertyHistory/Private/PropertyHistoryUtilities.h +++ b/Source/PropertyHistory/Private/PropertyHistoryUtilities.h @@ -3,9 +3,13 @@ #pragma once #include "CoreMinimal.h" +#include "UObject/UnrealType.h" +#include "Runtime/Launch/Resources/Version.h" #define PROPERTY_HISTORY_ENGINE_VERSION (ENGINE_MAJOR_VERSION * 100 + ENGINE_MINOR_VERSION) +class IInterface; + struct FLambdaCaller { template @@ -411,4 +415,4 @@ FProperty& FindFPropertyChecked_Impl(const FName Name) return Property; \ }()) -#define FindFPropertyChecked(Class, Name) FindFPropertyChecked_ByName(Class, GET_MEMBER_NAME_CHECKED(Class, Name)) \ No newline at end of file +#define FindFPropertyChecked(Class, Name) FindFPropertyChecked_ByName(Class, GET_MEMBER_NAME_CHECKED(Class, Name)) diff --git a/Source/PropertyHistory/Private/SPropertyHistory.cpp b/Source/PropertyHistory/Private/SPropertyHistory.cpp index 4ee359a..80b8053 100644 --- a/Source/PropertyHistory/Private/SPropertyHistory.cpp +++ b/Source/PropertyHistory/Private/SPropertyHistory.cpp @@ -4,12 +4,18 @@ #include "IDetailTreeNode.h" #include "IDetailPropertyRow.h" #include "IPropertyRowGenerator.h" -#include "ISourceControlRevision.h" #include "PropertyHistoryUtilities.h" #include "Widgets/Images/SThrobber.h" #include "Widgets/Layout/SScaleBox.h" #include "Framework/Commands/GenericCommands.h" #include "InstancedPropertyBagStructureDataProvider.h" +#include "ISourceControlRevision.h" +#include "Framework/MultiBox/MultiBoxBuilder.h" +#include "Misc/ConfigCacheIni.h" +#include "Modules/ModuleManager.h" +#include "Styling/StyleColors.h" +#include "Widgets/Layout/SSeparator.h" +#include "Widgets/Layout/SSpacer.h" void SPropertyHistory::Construct(const FArguments& Args) { @@ -559,7 +565,7 @@ FSlateColor SPropertyEntry::GetRowBackgroundColor(const int32 IndentLevel, const } } - static const uint8 ColorOffsets[] = + static constexpr uint8 ColorOffsets[] = { 0, 4, (4 + 2), (6 + 4), (10 + 6) }; @@ -827,4 +833,4 @@ FSlateColor SPropertyEntryRowIndent::GetRowBackgroundColor(const int32 IndentLev return SPropertyEntry::GetRowBackgroundColor( IndentLevel, Row && Row->IsHovered()); -} \ No newline at end of file +} diff --git a/Source/PropertyHistory/Private/SPropertyHistory.h b/Source/PropertyHistory/Private/SPropertyHistory.h index c68e76c..32895ce 100644 --- a/Source/PropertyHistory/Private/SPropertyHistory.h +++ b/Source/PropertyHistory/Private/SPropertyHistory.h @@ -5,6 +5,8 @@ #include "CoreMinimal.h" #include "DetailColumnSizeData.h" #include "PropertyHistoryHandler.h" +#include "Widgets/SCompoundWidget.h" +#include "Widgets/Views/STreeView.h" class SPropertyHistory : public SCompoundWidget { @@ -86,4 +88,4 @@ class SPropertyEntryRowIndent : public SCompoundWidget private: TWeakPtr WeakRow; -}; \ No newline at end of file +};