Skip to content

src/libmpdclient.c: 2 * Suspicious condition #28

@dcb314

Description

@dcb314

qmpdclient/src/libmpdclient.c:452]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

Source code is

while((ret = select(connection->sock+1,NULL,&fds,NULL,&tv)==1) ||

Maybe better code

while(((ret = select(connection->sock+1,NULL,&fds,NULL,&tv)) == 1) ||

qmpdclient/src/libmpdclient.c:533]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

if((err = select(connection->sock+1,&fds,NULL,NULL,&tv) == 1)) {

Duplicate.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions