-
Notifications
You must be signed in to change notification settings - Fork 26
Open
Description
qmpdclient/src/libmpdclient.c:452]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
Source code is
while((ret = select(connection->sock+1,NULL,&fds,NULL,&tv)==1) ||
Maybe better code
while(((ret = select(connection->sock+1,NULL,&fds,NULL,&tv)) == 1) ||
qmpdclient/src/libmpdclient.c:533]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
if((err = select(connection->sock+1,&fds,NULL,NULL,&tv) == 1)) {
Duplicate.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels