Skip to content
This repository was archived by the owner on Mar 17, 2023. It is now read-only.
This repository was archived by the owner on Mar 17, 2023. It is now read-only.

questions from vectorizer.py #1

@hustmonk

Description

@hustmonk

It's a good job.

When I read the code, I find some questions as follows:

(1)
self.initial_vectorizer = CountVectorizer(ngram_range=(1, 2), min_df = 3 / len(input_text), max_df=.4)
need to change 3 to 3., or min_df = 0

(2) For every term, you compute fisher_exact, and choose the terms with the higher pval.
maybe you should choose the lower pval.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions