-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
CSS/SASSissues in the CSS or SASSissues in the CSS or SASSdiscussionlong-form discussion about best approach, possible roadblocks, etclong-form discussion about best approach, possible roadblocks, etcoptimizationRefactoring 'wet' code into dry, opportunities to adhere to SRP, creating consistency in code, etcRefactoring 'wet' code into dry, opportunities to adhere to SRP, creating consistency in code, etcquestionFurther information is requestedFurther information is requested
Description
There are a number of ID selectors in the Base.scss file. Turing's style guide for CSS states:
- “While it is possible to select elements by ID in CSS, it should generally be considered an anti-pattern. ID selectors introduce an unnecessarily high level of specificity to your rule declarations, and they are not reusable.”
I think we should convert these to classes to have some more consistency, but I have a nagging feeling that these might be tied to the chartsJS functionality. I haven't used chartsJS yet, and so I'm not sure. Does anyone know if Charts require an ID to style?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
CSS/SASSissues in the CSS or SASSissues in the CSS or SASSdiscussionlong-form discussion about best approach, possible roadblocks, etclong-form discussion about best approach, possible roadblocks, etcoptimizationRefactoring 'wet' code into dry, opportunities to adhere to SRP, creating consistency in code, etcRefactoring 'wet' code into dry, opportunities to adhere to SRP, creating consistency in code, etcquestionFurther information is requestedFurther information is requested