From 554efb55a78b86d0d3fb35437e13dc5b21bcc7ef Mon Sep 17 00:00:00 2001 From: Chenkai Yao <40931032+ClConstantine@users.noreply.github.com> Date: Tue, 16 Sep 2025 11:35:02 +0800 Subject: [PATCH 1/2] Fix Quick Start in docs The variable definition `padded_dim` is missing. The call of function `rabitqlib::quant::reconstruct_vec` should get the raw data of the vector `code`. --- docs/docs/quick_start.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/docs/quick_start.md b/docs/docs/quick_start.md index 2abe7d4..91d837f 100644 --- a/docs/docs/quick_start.md +++ b/docs/docs/quick_start.md @@ -41,9 +41,10 @@ int main() { vector.data(), dim, bits, code.data(), delta, vl, config ); - // reconstruct + // reconstruct + size_t padded_dim = dim; float * reconstructed_data = new float [padded_dim]; - rabitqlib::quant::reconstruct_vec(code, delta, vl, padded_dim, reconstructed_data); + rabitqlib::quant::reconstruct_vec(code.data(), delta, vl, padded_dim, reconstructed_data); return 0; } From a59dfe8d51042c484364351184f2e8bc5ce2e0f1 Mon Sep 17 00:00:00 2001 From: Chenkai Yao <40931032+ClConstantine@users.noreply.github.com> Date: Tue, 16 Sep 2025 11:56:14 +0800 Subject: [PATCH 2/2] Fix Quick Start in docs Use vector uniformly in code. --- docs/docs/quick_start.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/docs/quick_start.md b/docs/docs/quick_start.md index 91d837f..e49069a 100644 --- a/docs/docs/quick_start.md +++ b/docs/docs/quick_start.md @@ -43,8 +43,8 @@ int main() { // reconstruct size_t padded_dim = dim; - float * reconstructed_data = new float [padded_dim]; - rabitqlib::quant::reconstruct_vec(code.data(), delta, vl, padded_dim, reconstructed_data); + std::vector reconstructed_data(padded_dim); + rabitqlib::quant::reconstruct_vec(code.data(), delta, vl, padded_dim, reconstructed_data.data()); return 0; }