Update for new Fondry version

[theczarek]

Any chance for update to Foundry 9.x ?

[SwordofSpirit]

Please, somebody do this.

[Fridan99]

I think this module is super useful, any plans to upgrade to v9? It does NOT seem to work in v9

[Thorarin]

I haven't extensively tested, but it works for me so far with 9.245.
Update to indicate compatibility (if it all works of course) would still be nice :)

[Fridan99]

I haven't extensively tested, but it works for me so far with 9.245.
Update to indicate compatibility (if it all works of course) would still be nice :)

In my case it doesn't work, neither with 9.245 nor with 9.249.... in fact I don't even see the word “Scenery” when right click on the scene.

[Thorarin]

This is with 9.249:

What other modules do you have enabled? Perhaps there is some incompatibility?

[SwordofSpirit]

I just tested on both 9.245 and 9.249. In each case,I can see the option (like in the picture above) but nothing happens when clicking on it (I just get an error in the console).

[Thorarin]

Sounds like an incompatibility with another add-on to me, because I can add and switch variants normally in Chrome, Firefox and Edge 🤔

[SwordofSpirit]

What version of the module do you have? Because I have 0.1.4 and it will not work. I've tried it on the Electron browser locally, and via Chrome logging into a web-hosted option, and I can see the "Scenery" option, but clicking it brings up nothing but an error in the console. Brand new worlds, no modules.

This is DnD 5e system, so I don't know if that's the difference.

[Fridan99]

In my case I can't even see the Scenery.... option and while I have the module active I can't change the map in the scene itself.

[VincentIliano]

The console error:

TypeError: Cannot read properties of undefined (reading 'getFlag')
[Detected 1 package: scenery]
at Scenery.getData (Scenery.js:29:29)

[Beerbill]

Can confirm there is a error in this package:

async getData() {
    const flag = this.scene.getFlag('scenery', 'data') || {};
    if (!this.bg) this.bg = flag.bg || this.scene.data.img;
    if (!this.gm) this.gm = flag.gm || this.scene.data.img;
    if (!this.pl) this.pl = flag.pl || this.scene.data.img;
    if (!this.variations) {
      this.variations = [{ name: 'Default', file: this.bg }];
      if (flag.variations) flag.variations.forEach((v) => this.variations.push(v));
    }

    // Add extra empty variation
    this.variations.push({ name: '', file: '' });
    // Return data to the template
    return { variations: this.variations, gm: this.gm, pl: this.pl };
}

anyone had any luck fixing it?

[Beerbill]

Managed to fix it!

scenery/scripts/classes/Scenery.js/

line 212

 static _onContextMenu(html, entryOptions) {
    const viewOption = {
      name: game.i18n.localize('SCENERY.scenery'),
      icon: '<i class="fas fa-images"></i>',
      condition: () => game.user.isGM,
      callback: (el) => {
        const id = el.attr('data-entity-id') || el.attr('data-scene-id');
        new Scenery(id).render(true);
      },
    };
    entryOptions.push(viewOption);
  }

change it to:

 static _onContextMenu(html, entryOptions) {
    const viewOption = {
      name: game.i18n.localize('SCENERY.scenery'),
      icon: '<i class="fas fa-images"></i>',
      condition: () => game.user.isGM,
      callback: (el) => {
        const id = el.attr('data-document-id') || el.attr('data-entity-id') || el.attr('data-scene-id');
        new Scenery(id).render(true);
      },
    };
    entryOptions.push(viewOption);
  }

I think they renamed the menu items to document instead of entity or scene. It's working for me :D

[Fridan99]

It works like a charm.... yo are a genius.

[SwordofSpirit]

Thanks!