-
Notifications
You must be signed in to change notification settings - Fork 59
Fix @filter behavior in phpgrep rules #1200
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't working
Description
dynamic rules @filter should work like phpgrep CLI filters.
What should be changed:
- There should be no restrictions on the variable expression.
${"x:const"}should work as well as$x; the:constpart specifies the node class - When matching,
$xwith a filter should not be limited to variables;$xmatches anything in phpgrep. Instead of matching by variable name after a type assertion, a text slice should be taken using the$xnode position info (it has begin+end positions). We usually have the current file source available during the analysis as[]byte.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working