[k2] revert "[k2] replace tl::is_int32_overflow with std::in_range (#1527)" (#1530)

It turns out it's intentional that the code didn't use standard
algorithms here. The reason for that is that it doesn't matter for
TL whether tl::int is signed or unsigned

This reverts commit 01a7aa6.

Author: apolyakov

runtime-light/stdlib/rpc/rpc-api.h

@@ -84,7 +84,7 @@ inline bool f$store_byte(int64_t v) noexcept {
 }
 
 inline bool f$store_int(int64_t v) noexcept {
-  if (!std::in_range<int32_t>(v)) [[unlikely]] {
+  if (tl::is_int32_overflow(v)) [[unlikely]] {
     kphp::log::warning("integer {} overflows int32, it will be cast to {}", v, static_cast<int32_t>(v));
   }
   tl::i32{.value = static_cast<int32_t>(v)}.store(RpcServerInstanceState::get().tl_storer);
@@ -243,7 +243,7 @@ inline bool f$rpc_parse(const Optional<string>& new_rpc_data) noexcept {
 class_instance<C$VK$TL$RpcFunction> f$rpc_server_fetch_request() noexcept;
 
 inline kphp::coro::task<bool> f$store_error(int64_t error_code, string error_msg) noexcept {
-  if (!std::in_range<int32_t>(error_code)) [[unlikely]] {
+  if (tl::is_int32_overflow(error_code)) [[unlikely]] {
     kphp::log::warning("error_code overflows int32, {} will be stored", static_cast<int32_t>(error_code));
   }
 

runtime-light/stdlib/rpc/rpc-tl-builtins.cpp

@@ -4,11 +4,9 @@
 
 #include "runtime-light/stdlib/rpc/rpc-tl-builtins.h"
 
-#include <cstdint>
-#include <utility>
-
 #include "runtime-light/server/rpc/rpc-server-state.h"
 #include "runtime-light/stdlib/diagnostics/logs.h"
+#include "runtime-light/tl/tl-core.h"
 
 mixed tl_arr_get(const mixed& arr, const string& str_key, int64_t num_key, int64_t precomputed_hash) noexcept {
   auto& cur_query{CurrentTlQuery::get()};
@@ -30,7 +28,7 @@ mixed tl_arr_get(const mixed& arr, const string& str_key, int64_t num_key, int64
 
 int32_t t_Int::prepare_int_for_storing(int64_t v) noexcept {
   auto v32{static_cast<int32_t>(v)};
-  if (!std::in_range<int32_t>(v)) [[unlikely]] {
+  if (tl::is_int32_overflow(v)) [[unlikely]] {
     if (RpcServerInstanceState::get().fail_rpc_on_int32_overflow) {
       CurrentTlQuery::get().raise_storing_error("Got int32 overflow with value '%" PRIi64 "'. Serialization will fail.", v);
     } else {

runtime-light/tl/tl-core.h

@@ -12,13 +12,19 @@
 #include <span>
 #include <utility>
 
+#include "common/algorithms/find.h"
 #include "runtime-common/core/allocator/script-allocator.h"
 #include "runtime-common/core/std/containers.h"
 #include "runtime-light/metaprogramming/concepts.h"
 #include "runtime-light/stdlib/diagnostics/logs.h"
 
 namespace tl {
 
+inline bool is_int32_overflow(int64_t v) noexcept {
+  const auto v32{static_cast<int32_t>(v)};
+  return vk::none_of_equal(v, int64_t{v32}, int64_t{static_cast<uint32_t>(v32)});
+}
+
 class storer {
   static constexpr auto DEFAULT_BUFFER_CAPACITY = 1024;