Fix VNish get_config for list-based autotune presets response is a list#414
Open
MinersNederland wants to merge 1 commit intoUpstreamData:masterfrom
Open
Fix VNish get_config for list-based autotune presets response is a list#414MinersNederland wants to merge 1 commit intoUpstreamData:masterfrom
MinersNederland wants to merge 1 commit intoUpstreamData:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a VNish parsing issue where
get_config()assumesautotune_presets()returns a dict and calls.get("presets", []).Some VNish miners return a list instead, which caused:
AttributeError: 'list' object has no attribute 'get'APIError: Failed to call config ... while getting dataWhat changed
response.get("presets", [])Why
This prevents
get_data()from failing on miners that return list-based preset payloads, while preserving existing behavior for dict-based responses.Validation
confignow loads successfully andget_data()completes, reutning a valid pyasic.data.MinerData object containing all expected dataCompatibility
Backward compatible: existing dict-based VNish responses still behave the same.
Human AI Review
This fix was created with Github Copilot and has been human reviewed (albeit by an amateur ;P )