Skip to content

Bug in setDriver method of node #20

@Goose66

Description

@Goose66

In setDriver method of the Node class, the code logs a "No change..." message if the "report" parameter was set to False whether the value was actually changed or not:

if report and (changed or force):
    NLOGGER.debug('{}:{} Reporting set {} to {} to Polyglot'.format(self.address, self.name, driver, value))
    self.reportDriver(driver, force)
else:
    NLOGGER.debug('{}:{} No change in {}\'s value'.format(self.address, self.name, driver))

This probably should be:

if report:
    if changed or force:
        NLOGGER.debug('{}:{} Reporting set {} to {} to Polyglot'.format(self.address, self.name, driver, value))
        self.reportDriver(driver, force)
    else:
        NLOGGER.debug('{}:{} No change in {}\'s value'.format(self.address, self.name, driver))

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions