Request parameters validation

[volodymyrdovhan]

Hello,
please review the usage of PARAM_RAW parameter type:

• PARAM_RAW specifies a parameter that is not cleaned/processed in any way except the discarding of the invalid utf-8 characters.

It is recommended to use PARAM_RAW only for some specific cases, as it does not clean up the data.

Please consider more specific parameter type usage.

[francopantoja]

Dear all

Update to get more specifict type of parameter

Regards

[juacas]

This implementation is not right.
Renderable object must have all the state inside the object and request params should be passed in the constructor or via set methods.

Please, move calls to optional_params outside the renderable object.
It's a simple refactoring and will allow to reuse the objects in other future contexts.

Reference: https://moodledev.io/docs/4.4/apis/subsystems/output

It should hold all the data required for the renderer to display the page. This means we should perform all our logic such as database queries, page parameters and access checks in advance then pass the results as data to the renderable. The renderable then just takes that data and returns an HTML representation of it.