diff --git a/.github/workflows/python-app.yml b/.github/workflows/python-app.yml index fac1c0c..caf450b 100644 --- a/.github/workflows/python-app.yml +++ b/.github/workflows/python-app.yml @@ -1,34 +1,34 @@ # This workflow will install Python dependencies, run tests and lint with a single version of Python # For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python -# name: Python application -# on: -# push: -# branches: [ "main" ] -# pull_request: -# branches: [ "main" ] -# permissions: -# contents: read -# jobs: -# build: -# runs-on: ubuntu-latest -# steps: -# - uses: actions/checkout@v3 -# - name: Set up Python 3.10 -# uses: actions/setup-python@v3 -# with: -# python-version: "3.10" -# - name: Install dependencies -# run: | -# python -m pip install --upgrade pip -# cd examples/week_9/passwords_with_tests -# pip install flake8 pytest -# if [ -f requirements.txt ]; then pip install -r requirements.txt; fi -# - name: Lint with flake8 -# run: | -# # stop the build if there are Python syntax errors or undefined names -# flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics -# # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide -# flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics -# - name: Test with pytest -# run: | -# pytest +name: Python application +on: + push: + branches: [ "main" ] + pull_request: + branches: [ "main" ] +permissions: + contents: read +jobs: + build: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Set up Python 3.10 + uses: actions/setup-python@v3 + with: + python-version: "3.10" + - name: Install dependencies + run: | + python -m pip install --upgrade pip + cd examples/week_9/passwords_with_tests + pip install flake8 pytest + if [ -f requirements.txt ]; then pip install -r requirements.txt; fi + - name: Lint with flake8 + run: | + # stop the build if there are Python syntax errors or undefined names + # flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics + # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide + # flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics + - name: Test with pytest + run: | + pytest diff --git a/examples/week_9/passwords_with_tests/passwords/__init__.py b/examples/week_9/passwords_with_tests/passwords/__init__.py index aed0166..a6a689e 100644 --- a/examples/week_9/passwords_with_tests/passwords/__init__.py +++ b/examples/week_9/passwords_with_tests/passwords/__init__.py @@ -40,7 +40,7 @@ def signup(): body = request.get_json() username = body['username'] password = body['password'] + \ - app.config['PEPPER'] # + "Deliberately Broken" + app.config['PEPPER'] + "Deliberately Broken" salt = bcrypt.gensalt() hashed = bcrypt.hashpw(password.encode('utf-8'), salt) connection = db.get_db()