`BinNormalisationFromECAT8::read_norm_data` prepends path to full path

[paskino]

The following code prepends the directory path to the full path resulting in wrong paths if the data is not in the current directory, i.e. the norm_parser.data_file_name doesn't do what's expected.

STIR/src/recon_buildblock/BinNormalisationFromECAT8.cxx

Lines 238 to 242 in ff3d5ab

	char directory_name[max_filename_length];
	get_directory_name(directory_name, filename.c_str());
	char full_data_file_name[max_filename_length];
	strcpy(full_data_file_name, norm_parser.data_file_name.c_str());
	prepend_directory_name(full_data_file_name, directory_name);

[KrisThielemans]

We have

STIR/src/buildblock/utilities.cxx

Lines 285 to 288 in ff3d5ab

	prepend_directory_name(char* filename_with_directory, const char* const directory_name)
	{
	if (is_absolute_pathname(filename_with_directory) || directory_name == 0 || strlen(directory_name) == 0)
	return filename_with_directory;

So it should prepend only if the path given in the header is a relative path, which didn't seem to be the case in your example. Note that the test is_absolute_path is

STIR/src/buildblock/utilities.cxx

Lines 270 to 272 in ff3d5ab

	#else // defined(__OS_UNIX__)
	// absolute names start with '/'
	return filename_with_directory[0] == '/';

I cannot see the problem therefore, unless there is something wrong with the path in the header.

It might be good to do od -c norm.n.hdr to check about any funny characters.