Fatal Error - Cannot Upgrade WordPress

[scarstens]

Install the plugin, activate it and then goto the updates tab and try to update WordPress. You can "manually re-install the current version" with the button at the top.

At first I though it was just something I modified for my "one theme version" of your script, but its not. WordPress updates completely fail with this plugin activated.

Fatal error: Cannot redeclare class Plugin_Upgrader in /home/ibseth2/public_html/wlwp.sethmatics.com/wp-admin/includes/class-wp-upgrader.php on line 632

Note that its probably not the "best way" to fix the problem, but I wrapped my filter call like this to solve the issue:

if(!empty($_GET['action']) && $_GET['action'] == 'do-core-reinstall'); else {
require_once('updater-assets.php');
add_filter('site_transient_update_themes', 'transient_update_themes_filter');
}

Note that my filename and location might be different then how you have your programmed. Its just for reference. You might use this until somebody figures out a better way to detect and not include that class object twice.

[sboerrigter]

Same problem here. Wil this bug be fixed in the next version?

[scarstens]

I already have a fix ready, but the original theme author never accepted my last proposed changes so I'm not sure I'm going to bother contunuing to fork his plugin. I can tell you how to fix it though, simple find and change this line of code:
if(!empty($_GET['action']) && $_GET['action'] == 'do-core-reinstall'); else {

to be like this

if(!empty($_GET['action']) && ($_GET['action'] == 'do-core-reinstall' || $_GET['action'] == 'do-core-upgrade')); else {

[sboerrigter]

Thanks for the reply, but we already stopped using this plugin due to another bug and the lack of support.

[scarstens]

If you are "handy" with PHP you can follow the development of our open source theme that has a completely overhauled version of the theme updater built in:
https://github.com/WordPress-Phoenix/whitelabel-framework/tree/master/inc
-> updater-plugin.php & updater-assets.php

I don't think it currently watches for "all themes" but it works great for us to watch "1 theme". Just depends on your needs if that will work or not. If you have more questions or issues feel free to post where appropriate compared to what your using.

[sboerrigter]

Thanks for the offer. Maybe I will take a look at your code later. For now we will do without an theme update function.