Improve generator robustness and file transformation

Enhance template copying to prevent infinite recursion and improve file detection. Consolidate text transformations into a unified system for better maintainability.

Author: voltechs

lib/gemplate/generator.rb

@@ -20,15 +20,21 @@ def create
     private
 
     def copy_template_structure
+      # Get list of all files/directories BEFORE creating the target directory
+      # This prevents infinite recursion when the target gets created
+      source_items = Dir.glob("#{@source_root}/*", File::FNM_DOTMATCH).map do |path|
+        filename = File.basename(path)
+        next if skip_file?(filename)
+        { source: path, filename: filename }
+      end.compact
+      
+      # Now create the target directory
       FileUtils.mkdir_p(@gem_name)
 
-      # Copy all files except those we want to exclude
-      Dir.glob("#{@source_root}/*", File::FNM_DOTMATCH).each do |source_path|
-        filename = File.basename(source_path)
-        
-        # Skip files we don't want to copy
-        next if skip_file?(filename)
-        
+      # Copy the pre-determined list of files
+      source_items.each do |item|
+        source_path = item[:source]
+        filename = item[:filename]
         dest_path = File.join(@gem_name, filename)
 
         if File.directory?(source_path)
@@ -47,15 +53,27 @@ def skip_file?(filename)
         '..'
       ]
 
-      # Skip any directory that looks like a generated gem (has a .gemspec file)
-      if File.directory?(File.join(@source_root, filename))
-        gemspec_pattern = File.join(@source_root, filename, "*.gemspec")
-        if Dir.glob(gemspec_pattern).any?
+      return true if excluded_files.include?(filename)
+      
+      # Skip any directory that looks like a generated gem
+      file_path = File.join(@source_root, filename)
+      if File.directory?(file_path)
+        # Skip if it has a gemspec file that's not the main gemplate.gemspec
+        gemspec_files = Dir.glob(File.join(file_path, "*.gemspec"))
+        if gemspec_files.any? && !gemspec_files.include?(File.join(file_path, "gemplate.gemspec"))
+          return true
+        end
+        
+        # Skip if it looks like a previously generated gem directory
+        if filename != 'lib' && filename != 'spec' && 
+           (File.exist?(File.join(file_path, "#{filename}.gemspec")) ||
+            File.exist?(File.join(file_path, "lib", filename)) ||
+            File.exist?(File.join(file_path, "lib", "#{filename}.rb")))
           return true
         end
       end
 
-      excluded_files.include?(filename)
+      false
     end
 
     def copy_directory(source_dir, dest_dir)
@@ -116,24 +134,14 @@ def transform_file_contents
       # Clean up files that shouldn't be in generated gems
       cleanup_unwanted_files
 
-      # Transform gemspec
-      transform_gemspec
-      
-      # Transform main lib file
-      transform_main_lib_file
+      # Remove CLI-specific files
+      remove_cli_files
 
-      # Transform version file
-      transform_version_file
+      # Apply global transformations to all text files
+      transform_all_files
 
-      # Transform spec files
-      transform_spec_helper
-      transform_spec_file
-      
-      # Transform README
-      transform_readme
-      
-      # Transform LICENSE
-      transform_license
+      # Create new README since the original is gemplate-specific
+      create_generic_readme
     end
 
     def cleanup_unwanted_files
@@ -158,86 +166,97 @@ def cleanup_unwanted_files
         end
       end
     end
-
-    def transform_gemspec
-      gemspec_file = File.join(@gem_name, "#{@gem_name}.gemspec")
-      return unless File.exist?(gemspec_file)
-      
-      content = File.read(gemspec_file)
-      content.gsub!(/require_relative 'lib\/gemplate\/version'/, "require_relative 'lib/#{@snake_name}/version'")
-      content.gsub!(/spec\.name\s*=\s*'gemplate'/, "spec.name          = '#{@gem_name}'")
-      content.gsub!(/Gemplate::VERSION/, "#{@module_name}::VERSION")
-      content.gsub!(/spec\.summary\s*=.*/, "spec.summary       = 'Write a short summary for your gem'")
-      content.gsub!(/spec\.description\s*=.*/, "spec.description   = 'Write a longer description for your gem'")
-      content.gsub!(/spec\.homepage\s*=.*/, "spec.homepage      = \"https://github.com/yourusername/#{@gem_name}\"")
-      content.gsub!(/spec\.authors\s*=.*/, "spec.authors       = ['Your Name']")
-      content.gsub!(/spec\.email\s*=.*/, "spec.email         = ['your.email@example.com']")
-      content.gsub!(/spec\.executables\s*=.*/, "spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }")
-      
-      File.write(gemspec_file, content)
-    end
-
-    def transform_main_lib_file
-      lib_file = File.join(@gem_name, 'lib', "#{@snake_name}.rb")
-      return unless File.exist?(lib_file)
-      
-      content = File.read(lib_file)
-      content.gsub!(/require_relative 'gemplate\//, "require_relative '#{@snake_name}/")
-      content.gsub!(/module Gemplate/, "module #{@module_name}")
-      
-      # Remove CLI-specific requires since this won't be a CLI gem
-      content.gsub!(/require_relative '#{@snake_name}\/cli'\n/, "")
-      content.gsub!(/require_relative '#{@snake_name}\/generator'\n/, "")
-      
-      # Remove CLI-specific files that shouldn't be in generated gems
-      cli_file = File.join(@gem_name, 'lib', @snake_name, 'cli.rb')
-      generator_file = File.join(@gem_name, 'lib', @snake_name, 'generator.rb')
-      
-      File.delete(cli_file) if File.exist?(cli_file)
-      File.delete(generator_file) if File.exist?(generator_file)
+    
+    def remove_cli_files
+      cli_files = [
+        File.join(@gem_name, 'lib', @snake_name, 'cli.rb'),
+        File.join(@gem_name, 'lib', @snake_name, 'generator.rb')
+      ]
 
-      File.write(lib_file, content)
+      cli_files.each { |file| File.delete(file) if File.exist?(file) }
     end
 
-    def transform_version_file
-      version_file = File.join(@gem_name, 'lib', @snake_name, 'version.rb')
-      return unless File.exist?(version_file)
-      
-      content = File.read(version_file)
-      content.gsub!(/module Gemplate/, "module #{@module_name}")
+    def transform_all_files
+      # Find all text files to transform
+      text_files = Dir.glob("#{@gem_name}/**/*", File::FNM_DOTMATCH).select do |file|
+        File.file?(file) && text_file?(file)
+      end
 
-      File.write(version_file, content)
+      text_files.each do |file_path|
+        content = File.read(file_path)
+        
+        # Apply all transformations
+        content = apply_transformations(content)
+        
+        File.write(file_path, content)
+      end
     end
-
-    def transform_spec_helper
-      spec_helper = File.join(@gem_name, 'spec', 'spec_helper.rb')
-      return unless File.exist?(spec_helper)
-      
-      content = File.read(spec_helper)
-      content.gsub!(/require 'gemplate'/, "require '#{@snake_name}'")
-      
-      File.write(spec_helper, content)
+    
+    def text_file?(file_path)
+      # Skip some specific binary file extensions
+      return false if file_path.end_with?('.png', '.jpg', '.jpeg', '.gif', '.ico', '.zip', '.tar', '.gz')
+      
+      # Simple check for text files - read first few bytes
+      begin
+        File.open(file_path, 'rb') do |file|
+          chunk = file.read(512)
+          return false if chunk.nil?
+          # If it contains null bytes, it's likely binary
+          return false if chunk.include?("\x00")
+        end
+        true
+      rescue
+        false
+      end
     end
-
-    def transform_spec_file
-      spec_file = File.join(@gem_name, 'spec', @snake_name, "#{@snake_name}_spec.rb")
-      return unless File.exist?(spec_file)
+    
+    def apply_transformations(content)
+      # Global find and replace patterns
+      transformations = {
+        # Module and class names
+        'Gemplate' => @module_name,
+        
+        # File paths and requires
+        "require_relative 'lib/gemplate/" => "require_relative 'lib/#{@snake_name}/",
+        "require_relative 'gemplate/" => "require_relative '#{@snake_name}/",
+        "require 'gemplate'" => "require '#{@snake_name}'",
+        
+        # Gem specification
+        "spec.name          = 'gemplate'" => "spec.name          = '#{@gem_name}'",
+        "'gemplate'" => "'#{@gem_name}'",
+        '"gemplate"' => "\"#{@gem_name}\"",
+        
+        # URLs and references
+        'TwilightCoders/gemplate' => "yourusername/#{@gem_name}",
+        
+        # Generic placeholders for new gems
+        /spec\.summary\s*=.*/ => "spec.summary       = 'Write a short summary for your gem'",
+        /spec\.description\s*=.*/ => "spec.description   = 'Write a longer description for your gem'",
+        /spec\.authors\s*=.*/ => "spec.authors       = ['Your Name']",
+        /spec\.email\s*=.*/ => "spec.email         = ['your.email@example.com']",
+        /spec\.executables\s*=.*/ => "spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }",
+        /Copyright \(c\) \d+ .+/ => "Copyright (c) #{Time.now.year} Your Name"
+      }
+      
+      # Remove CLI-specific requires
+      content.gsub!(/require_relative '#{@snake_name}\/cli'\n/, "")
+      content.gsub!(/require_relative '#{@snake_name}\/generator'\n/, "")
 
-      content = File.read(spec_file)
-      content.gsub!(/describe Gemplate/, "describe #{@module_name}")
-      content.gsub!(/Gemplate::VERSION/, "#{@module_name}::VERSION")
-      content.gsub!(/Gemplate\.root/, "#{@module_name}.root")
+      # Apply all transformations
+      transformations.each do |pattern, replacement|
+        if pattern.is_a?(Regexp)
+          content.gsub!(pattern, replacement)
+        else
+          content.gsub!(pattern, replacement)
+        end
+      end
 
-      File.write(spec_file, content)
+      content
     end
 
-    def transform_readme
+    def create_generic_readme
       readme_file = File.join(@gem_name, 'README.md')
-      return unless File.exist?(readme_file)
-      
-      content = File.read(readme_file)
 
-      # Replace the entire README with a generic template
       new_content = <<~README
         # #{@module_name}
 
@@ -281,16 +300,6 @@ def transform_readme
       File.write(readme_file, new_content)
     end
 
-    def transform_license
-      license_file = File.join(@gem_name, 'LICENSE.txt')
-      return unless File.exist?(license_file)
-      
-      content = File.read(license_file)
-      content.gsub!(/Copyright \(c\) \d+ .+/, "Copyright (c) #{Time.now.year} Your Name")
-      
-      File.write(license_file, content)
-    end
-
     def show_created_files
       Dir.glob("#{@gem_name}/**/*", File::FNM_DOTMATCH).sort.each do |file|
         next if File.directory?(file)