Merged
Conversation
- Remove broken Turing integration tests (p0.jl, p1.jl, p2.jl) and the runtests.jl that included them. - Use Chairmarks (it's just much faster) - Improved printing of results - General modernisation of the script. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Libtask.jl documentation for PR #213 is available at: |
penelopeysm
commented
Feb 21, 2026
| jobs: | ||
| test: | ||
| runs-on: ${{ matrix.os }} | ||
| continue-on-error: true # ${{ matrix.version == 'nightly' }} |
Member
Author
There was a problem hiding this comment.
CI was always passing even if tests failed (!!!!!)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
penelopeysm
changed the title
Closes #208 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
We are spawning a slightly silly number of runners for the new Turing integration test. I think it is important to make sure that the Turing integration test passes on all combinations, because Turing is the raison d'etre of Libtask. We should test Turing integration as seriously as we test Libtask itself. The good news is that all of these jobs are very short, so it's totally fine in terms of the GitHub runner workload. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the severely outdated scripts in the
perffolder (nobody bothered to update them, even when Libtask got rewritten, and even when there was a major effort in updating Libtask for Julia 1.12).In its place we add a new set of integration tests with Turing. This set is fairly basic and just aims to show that sampling with SMC / PG actually works. This replaces the old strategy of running the entire Turing test suite, which was wasteful and led to incidents like #207.
Over time this set of tests can be expanded to cover other problematic models, such as those in the other open issues.