pyz_binary is missing the PyZProvider

[cmoore3]

In order to write unit tests for pyz_binary content, my team wants to be able to add pyz_test rules that have deps on pyz_binary targets.

Unfortunately, that triggers an error because pyz_binary rules do not have the mandatory provider PyZProvider. That is also different behavior than the native rules where py_binary rules do have the py provider.

Simply updating this line to return [provider, DefaultInfo( seems to make it work as desired:
https://github.com/TriggerMail/rules_pyz/blob/master/rules_python_zip/rules_python_zip.bzl#L243

My question is, why is the provider omitted from pyz_binary rules? Can it be added?

[evanj]

Interesting! Mostly because I didn't consider this case. I thought the Python rules should work the way that C++, Java, and Go rules work: if you want to share code, it needs to be in a *_library rule. The *_binary rules only produce an executable. However, you make a good point that it would be good to be similar to the py_binary rule.

We've decided to not use Bazel, so this is basically unmaintained. I am unlikely to have time to look into this, sorry. :(