Skip to content

Latest commit

ย 

History

History
83 lines (64 loc) ยท 3.29 KB

File metadata and controls

83 lines (64 loc) ยท 3.29 KB

backend

โœ‰๏ธ Commit Messge Rules

์„œ๋ฒ„ ๋“ค์˜ Git Commit Message Rules

  • ๋ฐ˜์˜์‚ฌํ•ญ์„ ๋ฐ”๋กœ ํ™•์ธํ•  ์ˆ˜ ์žˆ๋„๋ก ์ž‘์€ ๊ธฐ๋Šฅ ํ•˜๋‚˜๋ผ๋„ ๊ตฌํ˜„๋˜๋ฉด ์ปค๋ฐ‹์„ ๊ถŒ์žฅํ•ฉ๋‹ˆ๋‹ค.
  • ๊ธฐ๋Šฅ ๊ตฌํ˜„์ด ์™„๋ฒฝํ•˜์ง€ ์•Š์„ ๋•, ๊ฐ์ž ๋ธŒ๋žœ์น˜์— ์ปค๋ฐ‹์„ ํ•ด์ฃผ์„ธ์š”.

๐Ÿ“Œ Commit Convention

[ํƒœ๊ทธ] ์ œ๋ชฉ์˜ ํ˜•ํƒœ

ํƒœ๊ทธ ์ด๋ฆ„ ์„ค๋ช…
FEAT ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ•  ๊ฒฝ์šฐ
FIX ๋ฒ„๊ทธ๋ฅผ ๊ณ ์นœ ๊ฒฝ์šฐ
CHORE ์งœ์ž˜ํ•œ ์ˆ˜์ •
DOCS ๋ฌธ์„œ ์ˆ˜์ •
INIT ์ดˆ๊ธฐ ์„ค์ •
TEST ํ…Œ์ŠคํŠธ ์ฝ”๋“œ, ๋ฆฌํŽ™ํ† ๋ง ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ถ”๊ฐ€
RENAME ํŒŒ์ผ ํ˜น์€ ํด๋”๋ช…์„ ์ˆ˜์ •ํ•˜๊ฑฐ๋‚˜ ์˜ฎ๊ธฐ๋Š” ์ž‘์—…์ธ ๊ฒฝ์šฐ
STYLE ์ฝ”๋“œ ํฌ๋งทํŒ…, ์„ธ๋ฏธ์ฝœ๋ก  ๋ˆ„๋ฝ, ์ฝ”๋“œ ๋ณ€๊ฒฝ์ด ์—†๋Š” ๊ฒฝ์šฐ
REFACTOR ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง

์ปค๋ฐ‹ ํƒ€์ž…

  • [ํƒœ๊ทธ] ์„ค๋ช… ํ˜•์‹์œผ๋กœ ์ปค๋ฐ‹ ๋ฉ”์‹œ์ง€๋ฅผ ์ž‘์„ฑํ•ฉ๋‹ˆ๋‹ค.
  • ํƒœ๊ทธ๋Š” ์˜์–ด๋ฅผ ์“ฐ๊ณ  ๋Œ€๋ฌธ์ž๋กœ ์ž‘์„ฑํ•ฉ๋‹ˆ๋‹ค.

์˜ˆ์‹œ >

  [FEAT] ๊ฒ€์ƒ‰ api ์ถ”๊ฐ€

๐Ÿ’ป Github mangement

WorkFlow : Gitflow Workflow

  • Develop, Feature, Hotfix ๋ธŒ๋žœ์น˜

  • ๊ฐœ๋ฐœ(develop): ๊ธฐ๋Šฅ๋“ค์˜ ํ†ตํ•ฉ ๋ธŒ๋žœ์น˜

  • ๊ธฐ๋Šฅ ๋‹จ์œ„ ๊ฐœ๋ฐœ(feature): ๊ธฐ๋Šฅ ๋‹จ์œ„ ๋ธŒ๋žœ์น˜

  • ๋ฒ„๊ทธ ์ˆ˜์ • ๋ฐ ๊ฐ‘์ž‘์Šค๋Ÿฐ ์ˆ˜์ •(hotfix): ์ˆ˜์ • ์‚ฌํ•ญ ๋ฐœ์ƒ ์‹œ ๋ธŒ๋žœ์น˜

  • ๊ฐœ๋ฐœ ๋ธŒ๋žœ์น˜ ์•„๋ž˜ ๊ธฐ๋Šฅ๋ณ„ ๋ธŒ๋žœ์น˜๋ฅผ ๋งŒ๋“ค์–ด ์ž‘์„ฑํ•ฉ๋‹ˆ๋‹ค.

โœ๐Ÿป Code Convention

์—์–ด๋น„์•ค๋น„ ์ฝ”๋“œ ์ปจ๋ฒค์…˜

๐Ÿ“ Gitflow ๊ทœ์น™

  • Develop์— ์ง์ ‘์ ์ธ commit, push๋Š” ๊ธˆ์ง€ํ•ฉ๋‹ˆ๋‹ค.
  • ์ปค๋ฐ‹ ๋ฉ”์„ธ์ง€๋Š” ๋‹ค๋ฅธ ์‚ฌ๋žŒ๋“ค์ด ๋ด๋„ ์ดํ•ดํ•  ์ˆ˜ ์žˆ๊ฒŒ ์จ์ฃผ์„ธ์š”.
  • ์ž‘์—… ์ด์ „์— issue ์ž‘์„ฑ ํ›„ pullrequest ์™€ issue๋ฅผ ์—ฐ๋™ํ•ด ์ฃผ์„ธ์š”.
  • ํ’€๋ฆฌํ€˜์ŠคํŠธ๋ฅผ ํ†ตํ•ด ์ฝ”๋“œ ๋ฆฌ๋ทฐ๋ฅผ ์ „์›์ด ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ์ง„ํ–‰ํ•ฉ๋‹ˆ๋‹ค.
  • ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ ์‹œ ๊ฐœ๋ฐœ ๋ธŒ๋žœ์น˜์—์„œ feature/๊ธฐ๋Šฅ ์œผ๋กœ ๋ธŒ๋žœ์น˜๋ฅผ ํŒŒ์„œ ๊ด€๋ฆฌํ•ฉ๋‹ˆ๋‹ค.
  • feature ์ž์„ธํ•œ ๊ธฐ๋Šฅ ํ•œ ๊ฐ€์ง€๋ฅผ ๋‹ด๋‹นํ•˜๋ฉฐ, ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ์ด ์™„๋ฃŒ๋˜๋ฉด ๊ฐ์ž์˜ ๋ธŒ๋žœ์น˜๋กœ Pull Request๋ฅผ ๋ณด๋ƒ…๋‹ˆ๋‹ค.
  • ๊ฐ์ž๊ฐ€ ๊ธฐ๊ฐ„ ๋™์•ˆ ๋งก์€ ์—ญํ• ์„ ์ „๋ถ€ ์ˆ˜ํ–‰ํ•˜๋ฉด, ๊ฐ์ž ๋ธŒ๋žœ์น˜์—์„œ develop๋ธŒ๋žœ์น˜๋กœ Pull Request๋ฅผ ๋ณด๋ƒ…๋‹ˆ๋‹ค.
  • develop ๋ธŒ๋žœ์น˜๋กœ์˜ Pull Request๋Š” ์ƒ๋Œ€๋ฐฉ์˜ ์ฝ”๋“œ๋ฆฌ๋ทฐ ํ›„์— mergeํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

โ—๏ธ branch naming convention

  • develop
  • feature/issue_number-๋„๋ฉ”์ธ-http Method-api
  • fix/issue_number-๋„๋ฉ”์ธ-http Method-api
  • release/version_number
  • hotfix/issue_number - Short Description

์˜ˆ์‹œ >

  feature/#3-user-post-api

๐Ÿ“‹ Code Review Convention

  • P1: ๊ผญ ๋ฐ˜์˜ํ•ด์ฃผ์„ธ์š” (Request changes)
  • P2: ์ ๊ทน์ ์œผ๋กœ ๊ณ ๋ คํ•ด์ฃผ์„ธ์š” (Request changes)
  • P3: ์›ฌ๋งŒํ•˜๋ฉด ๋ฐ˜์˜ํ•ด ์ฃผ์„ธ์š” (Comment)
  • P4: ๋ฐ˜์˜ํ•ด๋„ ์ข‹๊ณ  ๋„˜์–ด๊ฐ€๋„ ์ข‹์Šต๋‹ˆ๋‹ค (Approve)
  • P5: ๊ทธ๋ƒฅ ์‚ฌ์†Œํ•œ ์˜๊ฒฌ์ž…๋‹ˆ๋‹ค (Approve)

๐Ÿš€ Test Code Convention

  1. given, when, then์„ ์‚ฌ์šฉํ•œ๋‹ค.
  2. ํ…Œ์ŠคํŠธ ๋ฉ”์„œ๋“œ๋ช…์€ ๋‹ค์Œ๊ณผ ๊ฐ™์ด ์ž‘์„ฑํ•œ๋‹ค. -> ๋ฉ”์„œ๋“œ๋ช…_ํ…Œ์ŠคํŠธํ•˜๊ณ ์žํ•˜๋Š”์ƒํƒœ_์˜ˆ์ƒ๋˜๋Š”๊ฒฐ๊ณผ (ex. giveCotton_CottonCountIs0_NotEnoughCotton)
  3. ์„ค๋งˆ ์ด๋Ÿฐ ๊ฑฐ๊นŒ์ง€ ์ƒ๊ฐํ•ด์•ผํ•˜๋‚˜์‹ถ์€ ๊ฑฐ๊นŒ์ง€ ์ž‘์„ฑํ•œ๋‹ค. (ex. ์†œ๋ญ‰์น˜๋ฅผ ์—ฌ๋Ÿฌ ๊ฐœ ์ค„ ์ˆ˜ ์žˆ๋‹ค.)
  4. ๋‹ค์ˆ˜์˜ ๊ฐ’์„ ๋‹ค๋ฃฐ ๋•Œ๋Š” @ParameterizedTest๋ฅผ ํ™œ์šฉํ•œ๋‹ค.