Add input as as ancestor of itself

[amykglen]

I noticed that the Biolink Lookup Service seems to return only proper ancestors (i.e., excluding the input item), but all descendants (i.e., including the input item).

for example, this ancestor query for MolecularMixture:

curl -X GET "https://bl-lookup-sri.renci.org/bl/MolecularMixture/ancestors?version=2.1.0" -H  "accept: application/json"

does not return MolecularMixture:

[
  "biolink:ChemicalMixture",
  "biolink:ChemicalEntity",
  "biolink:NamedThing",
  "biolink:Entity",
  "biolink:PhysicalEssence",
  "biolink:PhysicalEssenceOrOccurrent",
  "biolink:ChemicalOrDrugOrTreatment",
  "biolink:ChemicalEntityOrGeneOrGeneProduct",
  "biolink:ChemicalEntityOrProteinOrPolypeptide"
]

but this descendant query for MolecularMixture:

curl -X GET "https://bl-lookup-sri.renci.org/bl/MolecularMixture/descendants?version=2.1.0" -H  "accept: application/json"

does return MolecularMixture:

[
  "biolink:MolecularMixture",
  "biolink:Drug"
]

is this deliberate? the inconsistency seems a bit odd to me.

[cbizon]

I think this is a duplicate - but let me know if that is wrong.

[amykglen]

@cbizon - sorry, what issue is this a duplicate for? It's not the same as #42 - doesn't involve mixins.

[cbizon]

oops, thanks for pointing that out

[cbizon]

Ah, my reading comprehension needs some work - yes I agree that this is inconsistent. Do you have a preference on which direction we should standardize. I don't particularly.

[amykglen]

I'd prefer that the input item is returned as an ancestor/descendant of itself, but I'm fine with either way (easy enough to add the input item to the returned items).

[cbizon]

I'm pretty sure that there's an option on the BMT calls for ancestor / descendant. Not sure if it shares this inconsistancy or not, but it's easy to fix up at the service level.