From 80237bdd624bdb6306ac03eee31ba66ea6fbaf58 Mon Sep 17 00:00:00 2001
From: Tony <44562332+TonyGuy@users.noreply.github.com>
Date: Sat, 28 Mar 2026 15:35:30 +0800
Subject: [PATCH] fix(ui): seed CCXT select defaults and validate connection
 fields in account wizard

Controlled selects did not set `exchange` until changed, leaving it undefined for
Zod validation. Initialize select fields without metadata defaults to the first
option, require connection fields before step 2, and gate Next/Create accordingly.
---
 ui/src/pages/TradingPage.tsx | 25 ++++++++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)

diff --git a/ui/src/pages/TradingPage.tsx b/ui/src/pages/TradingPage.tsx
index 99dc46d1..b07c8d42 100644
--- a/ui/src/pages/TradingPage.tsx
+++ b/ui/src/pages/TradingPage.tsx
@@ -370,7 +370,13 @@ function CreateWizard({ brokerTypes, existingAccountIds, onSave, onClose }: {
     if (!bt) return
     const defaults: Record<string, unknown> = {}
     for (const f of bt.fields) {
-      if (f.default !== undefined) defaults[f.name] = f.default
+      if (f.default !== undefined) {
+        defaults[f.name] = f.default
+      } else if (f.type === 'select' && f.options?.length) {
+        // Controlled <select> with value "" does not fire onChange when the UI shows the
+        // first option — user must pick explicitly or we seed the first value here.
+        defaults[f.name] = f.options[0].value
+      }
     }
     setBrokerConfig(defaults)
   }, [type])
@@ -386,12 +392,20 @@ function CreateWizard({ brokerTypes, existingAccountIds, onSave, onClose }: {
     badgeColor: b.badgeColor,
   }))
 
+  const connectionRequiredOk = connectionFields
+    .filter(f => f.required)
+    .every(f => String(brokerConfig[f.name] ?? '').trim())
+
   const handleNext = () => {
     if (!type) return
     if (existingAccountIds.includes(finalId)) {
       setError(`Account "${finalId}" already exists`)
       return
     }
+    if (hasSensitive && !connectionRequiredOk) {
+      setError('Please complete all required connection fields')
+      return
+    }
     setError('')
     if (hasSensitive) {
       setStep(2)
@@ -420,7 +434,8 @@ function CreateWizard({ brokerTypes, existingAccountIds, onSave, onClose }: {
   }
 
   const canCreate = hasSensitive
-    ? credentialFields.filter(f => f.required).every(f => String(brokerConfig[f.name] ?? '').trim())
+    ? connectionRequiredOk &&
+      credentialFields.filter(f => f.required).every(f => String(brokerConfig[f.name] ?? '').trim())
     : true
 
   return (
@@ -497,7 +512,11 @@ function CreateWizard({ brokerTypes, existingAccountIds, onSave, onClose }: {
           </button>
         )}
         {step === 1 && (hasSensitive || !type) && (
-          <button onClick={handleNext} disabled={!type} className="btn-primary">
+          <button
+            onClick={handleNext}
+            disabled={!type || (hasSensitive && !connectionRequiredOk)}
+            className="btn-primary"
+          >
             Next
           </button>
         )}