Skip to content

fix(socketio/ns): remove socket in case of ns connect failure #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Totodore merged 3 commits into from
Jan 24, 2026
Merged

fix(socketio/ns): remove socket in case of ns connect failure #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25248bb
fix(socketio/ns): remove socket in case of ns connect failure
Totodore Jan 24, 2026
2df6a14
fix(socketio/ns): remove socket in case of ns connect failure
Totodore Jan 24, 2026
e8b61bd
fix(socketio/ns): remove socket in case of ns connect failure
Totodore Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 9 additions & 3 deletions crates/socketioxide/src/ns.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,11 @@ impl<A: Adapter> Namespace<A> {
let data = e.to_string();
if let Err(_e) = socket.send(Packet::connect_error(self.path.clone(), data)) {
#[cfg(feature = "tracing")]
tracing::debug!("error sending connect_error packet: {:?}, closing conn", _e);
tracing::debug!(%sid, "error sending connect_error packet: {_e}, closing conn");

// user middleware code might have made the socket join some
// room in the local/remote adapter.
self.remove_socket(sid);
esocket.close(engineioxide::DisconnectReason::PacketParsingError);
}
return Err(ConnectFail);
Expand All @@ -132,8 +136,10 @@ impl<A: Adapter> Namespace<A> {
};
if let Err(_e) = socket.send(Packet::connect(self.path.clone(), payload)) {
#[cfg(feature = "tracing")]
tracing::debug!("error sending connect packet: {:?}, closing conn", _e);
esocket.close(engineioxide::DisconnectReason::PacketParsingError);
tracing::debug!(%sid, "error sending connect packet: {_e}, closing conn");

self.remove_socket(sid);
esocket.close(engineioxide::DisconnectReason::TransportError);
return Err(ConnectFail);
}

Expand Down
Loading