Error when upgrading PHP to 7.4

[alexmahan]

Hi, my web host recently required us to upgrade to PHP 7.4 from 7.2 for security reasons.

After upgrading, I receive this error on a page that uses Printmaker:

I'm not super knowledgeable at PHP so I'm hesitant to open a PR, but wondering if this is something that's relatively trivial to fix?

Thanks!

[michaelrog]

I'm not able to reproduce this offhand in my 7.4 env, but I'll be happy to look into it. If you can provide any more specific info (perhaps turn on Dev Mode to get a more detailed trace), that'd be very helpful!

[alexmahan]

Thanks for the quick reply!

Here's the stack trace while in dev mode:

The code in to generate the PDF url is:

 {% set vars = {
    body: entry.body
  } %}
  {% set settings = {
    orientation: 'portrait',
    filename: artistName ~ '-cv'
  } %}
  {% set pdfUrl = craft.printmaker.pdfFromTemplate('artists/_cvPdf', vars, settings).url %}
  <h2 class="-visually-hidden">{{ artistName }} – CV</h2>
  <a target="_blank" href="{{ pdfUrl }}" class="pdf-download">Download as PDF</a>
  {{ entry.body }}