Skip to content

Dunks/Quenches suggestion is slightly off for polish and grindstone #37

@izinman

Description

@izinman

Hello, first I wanted to say thanks for the great plugin, and I'm interested in contributing and implementing this myself is someone will be willing to review and merge my changes.

I would also like to note that I've exclusively been using Giant's Foundry with no smithing outfit and smithing level in the 60s, using steel+mithril, so some of my observations may not apply at higher levels or when using different metals, more testing would be required.

I've noticed that the suggested number of quenches or dunks are consistently a little off for polish and grindstone. For polish, I suspect the algorithm is failing to take into account the extra travel distance between the lava and the polish station, which results in the number of suggested actions being off by 1 (needs 1 more dunk /heat than is suggested). I haven't looked at the algorithm yet, but I think the simple fix here would be to apply a "fudge factor" to the output when the remaining heat is within a small window of the remaining actions, while also making sure not to overshoot.

Similarly, the waterfall will tend to suggest 1 more action than necessary when cooling for the grindstone. Again, I suspect that the travel time from the waterfall to the grindstone is allowing for slightly more passive cooling than what is calculated by the current algorithm, so similarly the "fudge factor" could be applied here to reduce the suggested cools/dunks by 1 if the resulting heat will be very close to the same as the number of remaining actions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions